Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TENSORLFOW] PlaceholderWithDefault (limited) implementation. #3184

Merged
merged 1 commit into from
May 16, 2019

Conversation

srkreddy1238
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@yongwww
Copy link
Member

yongwww commented May 13, 2019

I have the same workaround for PlaceholderWithDefault. Seems relay var doesn't have default value, probably we could store the default value in params, update params with real value if it exists. @jroesch @zhiics @icemelon9 pls suggest

@srkreddy1238
Copy link
Contributor Author

@yongwww The trick here is the default input may have dependency on graph inputs.

@tqchen tqchen merged commit c4439a8 into apache:master May 16, 2019
@srkreddy1238 srkreddy1238 deleted the tf-upgrade branch January 24, 2020 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants