Fix a bug of flatten in ONNX to Relay converter #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related pull request #2843 |
|
@zhreshold LGTM, thoughts? |
jroesch
approved these changes
May 11, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
* fix onnx frontend flatten bug * Update onnx.py * Update onnx.py * Update onnx.py
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
* fix onnx frontend flatten bug * Update onnx.py * Update onnx.py * Update onnx.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch_flatten, as it's name suggests, should flatten each data samples of a batch.
So we don't need to enhance batch_flatten to support another axis except batch_size axis.
As a result, we can do an optional conversion (convert to batch_flatten when the flatten op matches, use reshape otherwise).