[ARITH] Constraint-aware ConstIntBound, Enhance CanonicalSimplify #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@merrymercy @yzhliu @sgrechanik-h @kazum @kevinthesun please help review this PR |
sgrechanik-h
reviewed
May 2, 2019
| auto ret2 = DetectBoundInfo(y.Eval()); | ||
| ret1.insert(ret1.end(), ret2.begin(), ret2.end()); | ||
| return ret1; | ||
| } |
There was a problem hiding this comment.
Do we also need the x == c (and c == x) case?
There was a problem hiding this comment.
I am not very sure if this is a case that we will need as frequently, so I decided to leave it out after some thought. We can revisit later. This might be better suited for a condition in a simplifier. Most conditions like x % 3== 1 is detected by modular analysis.
yzhliu
approved these changes
May 3, 2019
sgrechanik-h
approved these changes
May 3, 2019
|
Thanks, @sgrechanik-h @yzhliu |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance constraints for const-int-bound, so that we can do the following simplification, that considers the constraints in the if_then_else condition. Enhance CanonicalSimplify to try to simplify base during mod.
This PR will likely improve or resolve condition brought in #3097.