Fix bug in ONNX importer #3084
Merged
Fix bug in ONNX importer #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zhreshold |
zhreshold
approved these changes
Apr 24, 2019
zhreshold
suggested changes
Apr 24, 2019
|
@jroesch @zhreshold please look into the CI case and decide an actionable item to move forward |
|
It looks like there was previously a bug in the old test case that was being silently ignored due the previous default. If there were no inputs in the constant fill case we still added an input to the graph even though we didn't pass one. The other fix would be we intended to pass an argument and to explicitly pass one. |
tqchen
added
status: accepted
and removed
status: need update
|
Thanks @jroesch @zhreshold @yzhliu , this is now merged |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes small bug in the ONNX importer that is very confusing, fix for #3079.
The importer previously would default to scalars when input shapes were not provided. This instead requires the user to explicitly provide all input shapes.