Relay C++ Build Module #3082

antinucleon · 2019-04-23T21:45:18Z

Currently most schedules are written in Python. I tested on CPU environment this building module is able to pass a dense + relu test with Python schedules. To fully replace Python build module, port some AutoTVM feature to C++ is necessary.

antinucleon · 2019-04-25T17:24:29Z

ping reviewers...

include/tvm/build_module.h

src/relay/backend/build_module.cc

include/tvm/build_module.h

jroesch · 2019-04-27T06:29:05Z

Sorry about the slow review, been a busy week! Thanks for rewriting so much code into C++, my feedback is mostly stylistic.

Can you review @MarisaKirisame?

jroesch · 2019-04-27T06:29:21Z

Sorry about the slow review, been a busy week! Thanks for rewriting so much code into C++, my feedback is mostly stylistic.

Can you review @MarisaKirisame?

src/relay/backend/build_module.cc

tests/python/relay/test_cpp_build_module.py

alex-weaver · 2019-04-28T10:30:16Z

General feedback: I would suggest a pass over the code to revise the \brief comments - try to include the purpose of the class/function.

include/tvm/build_module.h

src/relay/backend/build_module.cc

antinucleon · 2019-05-06T23:52:37Z

@jroesch Updated.

icemelon · 2019-05-07T18:56:10Z

@jroesch @MarisaKirisame @tqchen Could one of you review this PR again?

antinucleon · 2019-05-07T20:24:07Z

Updated.

src/relay/backend/build_module.cc

jroesch · 2019-05-07T23:25:23Z

@antinucleon Looks good to me, one last question when will we replace the Python code currently in build_module.py? having two code paths that do the same thing makes me nervous, it would be good to remove all that code if possible.

wweic

lgtm

antinucleon · 2019-05-07T23:39:45Z

@jroesch We have to wait AutoTVM is ported to C++, then we are able to replace Python build_module.

jroesch · 2019-05-07T23:46:42Z

Why can't we just expose the necessary Python functions and call them from C++?

src/codegen/build_module.cc

src/relay/backend/build_module.cc

MarisaKirisame · 2019-05-07T23:55:22Z

src/relay/backend/build_module.cc

+  std::unordered_set<std::string> disabled_pass;
+  OptPassLevel OPT_PASS_LEVEL;
+  inline bool pass_enabled(const std::string& pass_name) const {
+    if (disabled_pass.count(pass_name)) {


CHECK_GT(add_pass.count(pass_name), 0);
inside this if.
This will catch corner case where a pass_name is both enabled and disabled.

Disabled pass priority is higher than adding extra pass: see https://discuss.tvm.ai/t/relay-alter-op-layout-pass-regression/1870/2. I don't know any use case which people will enable some extra passes and disable at the same time.

Exactly, if there is no such use case, better just do not allow it, so in case ppl enable and disable by accident, there will be an immediate error.

My point is: There is no use case to both enable and disable a pass, but we may need O3 but disable some passes.

src/relay/backend/build_module.cc

antinucleon · 2019-05-08T00:22:03Z

@jroesch For fully migrating to C++, we have to do step by step, as the python module is not typed and fixing all these case need quite a lot of work.

jroesch · 2019-05-08T07:15:55Z

Ok sounds good. We can do it incrementally.

* [Relay] C++ Build module * asdf

antinucleon force-pushed the build branch from 739d4ee to 0dfdcaf Compare April 23, 2019 22:21

antinucleon changed the title ~~[WIP] Relay C++ Build Module~~ Relay C++ Build Module Apr 23, 2019

[Relay] C++ Build module

6ea243a

antinucleon force-pushed the build branch from 0dfdcaf to 6ea243a Compare April 24, 2019 05:22

antinucleon requested review from alex-weaver, icemelon and jroesch April 24, 2019 17:20

jroesch requested changes Apr 27, 2019

View reviewed changes

tqchen mentioned this pull request Apr 27, 2019

C++ Compiler API #1184

Closed

5 tasks

alex-weaver reviewed Apr 28, 2019

View reviewed changes

src/relay/backend/build_module.cc Outdated Show resolved Hide resolved

src/relay/backend/build_module.cc Outdated Show resolved Hide resolved

tests/python/relay/test_cpp_build_module.py Outdated Show resolved Hide resolved

MarisaKirisame reviewed Apr 29, 2019

View reviewed changes

jroesch self-assigned this May 1, 2019

jroesch added the status: need update need update based on feedbacks label May 1, 2019

antinucleon force-pushed the build branch 9 times, most recently from fe80f40 to cbdd452 Compare May 6, 2019 23:52

antinucleon force-pushed the build branch 3 times, most recently from c7fc5e7 to 05c828d Compare May 7, 2019 07:14

antinucleon force-pushed the build branch from 0cf45df to 6412ec4 Compare May 7, 2019 19:52

antinucleon force-pushed the build branch from 6412ec4 to 3d5798e Compare May 7, 2019 20:25

icemelon added status: need review and removed status: need update need update based on feedbacks labels May 7, 2019

icemelon approved these changes May 7, 2019

View reviewed changes

antinucleon force-pushed the build branch from 3d5798e to 28f927e Compare May 7, 2019 20:30

wweic reviewed May 7, 2019

View reviewed changes

src/relay/backend/build_module.cc Outdated Show resolved Hide resolved

src/relay/backend/build_module.cc Outdated Show resolved Hide resolved

antinucleon force-pushed the build branch 2 times, most recently from fdb9f8d to 532cbd3 Compare May 7, 2019 21:27

wweic approved these changes May 7, 2019

View reviewed changes

MarisaKirisame reviewed May 7, 2019

View reviewed changes

asdf

bcbef83

antinucleon force-pushed the build branch from 532cbd3 to bcbef83 Compare May 8, 2019 00:19

jroesch approved these changes May 8, 2019

View reviewed changes

jroesch merged commit b131d83 into apache:master May 8, 2019

icemelon added status: accepted and removed status: need review labels May 8, 2019

zhiics mentioned this pull request May 10, 2019

[Relay][Compilation] replace relay.build_module with C++ BuildModule #3174

Merged

wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019

Relay C++ Build Module (apache#3082)

f4bf163

* [Relay] C++ Build module * asdf

wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019

Relay C++ Build Module (apache#3082)

4ae2053

* [Relay] C++ Build module * asdf

tqchen mentioned this pull request May 16, 2019

[RFC] Relay C++ Frontend #2685

Closed

antinucleon deleted the build branch May 22, 2019 22:01

tqchen mentioned this pull request Nov 8, 2019

[RELEASE][DRAFT] TVM v0.6 Release candidate #4259

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relay C++ Build Module #3082

Relay C++ Build Module #3082

antinucleon commented Apr 23, 2019 •

edited

Loading

antinucleon commented Apr 25, 2019

jroesch commented Apr 27, 2019

jroesch commented Apr 27, 2019

alex-weaver commented Apr 28, 2019

antinucleon commented May 6, 2019

icemelon commented May 7, 2019

antinucleon commented May 7, 2019

jroesch commented May 7, 2019

wweic left a comment

antinucleon commented May 7, 2019

jroesch commented May 7, 2019

MarisaKirisame May 7, 2019

antinucleon May 8, 2019

MarisaKirisame May 8, 2019

antinucleon May 8, 2019 •

edited

Loading

antinucleon commented May 8, 2019

jroesch commented May 8, 2019

Relay C++ Build Module #3082

Relay C++ Build Module #3082

Conversation

antinucleon commented Apr 23, 2019 • edited Loading

antinucleon commented Apr 25, 2019

jroesch commented Apr 27, 2019

jroesch commented Apr 27, 2019

alex-weaver commented Apr 28, 2019

antinucleon commented May 6, 2019

icemelon commented May 7, 2019

antinucleon commented May 7, 2019

jroesch commented May 7, 2019

wweic left a comment

Choose a reason for hiding this comment

antinucleon commented May 7, 2019

jroesch commented May 7, 2019

MarisaKirisame May 7, 2019

Choose a reason for hiding this comment

antinucleon May 8, 2019

Choose a reason for hiding this comment

MarisaKirisame May 8, 2019

Choose a reason for hiding this comment

antinucleon May 8, 2019 • edited Loading

Choose a reason for hiding this comment

antinucleon commented May 8, 2019

jroesch commented May 8, 2019

antinucleon commented Apr 23, 2019 •

edited

Loading

antinucleon May 8, 2019 •

edited

Loading