[Relay][Runtime] Implementation of Relay VM #2889

jroesch · 2019-03-25T01:35:02Z

This represents the culmination of #2810.

The final version of the VM adapts ideas from both proposals into a unified design.
This PR is work from @wweic @icemelon9 @zhiics and I.

Review please:

cc @joshpoll @weberlo @MarisaKirisame @slyubomirsky @tqchen @nhynes @ZihengJiang @junrushao1994

tests/python/relay/model_zoo_data/lstm_i128_h128-symbol.json.data

include/tvm/relay/vm/vm.h

.gitmodules

wweic

let's get some unnecessary diffs out first.

src/relay/backend/interpreter.cc

python/tvm/relay/frontend/tensorflow.py

python/tvm/relay/prelude.py

src/relay/op/tensor/binary.cc

include/tvm/relay/expr.h

include/tvm/runtime/packed_func.h

python/tvm/relay/__init__.py

python/tvm/relay/_vm.py

python/tvm/relay/module.py

python/tvm/relay/ty.py

src/relay/ir/type_functor.cc

src/relay/op/tensor/reduce.cc

src/relay/pass/fuse_ops.cc

src/relay/pass/kind_check.cc

src/relay/pass/type_infer.cc

python/tvm/relay/frontend/mxnet.py

src/relay/op/tensor/reduce.cc

src/relay/pass/dead_code.cc

src/relay/vm/compiler.cc

src/relay/vm/lambda_lift.cc

src/relay/vm/vm.cc

MarisaKirisame · 2019-04-16T21:06:03Z

I had do a quick review and will do a more through one later.
This is a good time to discuss GC because we has cyclic data structure.

include/tvm/relay/vm/vm.h

include/tvm/runtime/object.h

src/relay/vm/compiler.cc

src/relay/vm/inline_primitives.cc

src/relay/vm/vm.cc

src/relay/vm/lambda_lift.cc

tqchen · 2019-04-17T23:24:30Z

reviewers, please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

@vinx13 @sgrechanik-h @junrushao1994 @kazum @hlu1 please also help review if you have time

include/tvm/relay/vm/vm.h

src/relay/pass/to_a_normal_form.cc

src/relay/vm/compiler.cc

docs/dev/virtual_machine.rst

python/tvm/_ffi/function.py

src/relay/pass/fuse_ops.cc

docs/dev/virtual_machine.rst

python/tvm/_ffi/function.py

Co-Authored-By: jroesch <[email protected]>

* Implement the virtual machine Co-Authored-By: wweic <[email protected]> * Fix rebase build issues * Reorganize vm.py and fix allocator bug * Remove compiler * Remove tests * Remove backend/vm/vm.cc too * Fix docs * Fix doc * Fix doc * Add vm docs * Remove change to dead_code.cc * Remove Relay logging * Remove reduce * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Reformat * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Address feedback * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Apply suggestions from code review Co-Authored-By: jroesch <[email protected]> * Fix a couple outstanding comments * Last couple comments * Update include/tvm/runtime/vm.h Co-Authored-By: jroesch <[email protected]> * Address code review feedback * Fix final comment * Address comments * Error reporting and example * add Const * Explicitly delete copy assignment operator * Fix rebase * Pass 3rd arg to fusion

tqchen requested changes Mar 25, 2019

View reviewed changes

tests/python/relay/model_zoo_data/lstm_i128_h128-symbol.json.data Outdated Show resolved Hide resolved

include/tvm/relay/vm/vm.h Outdated Show resolved Hide resolved

.gitmodules Outdated Show resolved Hide resolved

jroesch mentioned this pull request Mar 25, 2019

[RFC] Relay Dynamic Runtime #2810

Closed

wweic requested changes Mar 25, 2019

View reviewed changes

src/relay/backend/interpreter.cc Show resolved Hide resolved

python/tvm/relay/frontend/tensorflow.py Outdated Show resolved Hide resolved

python/tvm/relay/prelude.py Outdated Show resolved Hide resolved

jroesch mentioned this pull request Mar 26, 2019

Support Object in visit API dmlc/HalideIR#54

Merged

jroesch force-pushed the relay-rts branch 2 times, most recently from 1d28c24 to 02c0823 Compare March 26, 2019 08:49

icemelon added the status: WIP label Mar 29, 2019

jroesch marked this pull request as ready for review April 12, 2019 23:59

jroesch force-pushed the relay-rts branch 2 times, most recently from b4f7b73 to 59181eb Compare April 16, 2019 01:59