-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the conda build #2742
Conversation
Please request review and satisfy the CI (not sure whether simply re-triggering can work) |
CI problem was fixed, do another patch will retrigger |
Close/reopen usually retriggers CI for me, but it doesn't appear to work here. What should I "patch" to trigger it? Or should I just close this one and open a new one with the same commits? |
I spoke too soon, the CI is running again. |
It seems it crashed in the python tests this time. It might be due to the changes I made in setup.py but that would surprise me. I have no idea what caused this problem otherwise. |
I've removed the changes to setup.py since I don't really need them for this. This way I can be sure that if the build doesn't pass this time, it's not because I've broken anything. |
I might need some help here since I have no idea why the python tests keep crashing. I literally have made no changes outside of the conda packaging so I can't have caused this. Does anyone have a clue about what is wrong? |
Was caused by #2750, should be fixed by now |
I am going to directly merge this in given that the CI error is not related. Thanks @abergeron @yzhliu |
A collection to small fixes:
I've tried building support for Metal on OS X, but the anaconda compilers are stuck in the 10.9 era before the framework existed so not much luck there. I still want to revisit that later and probably switch to using the system compilers for that.