Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the conda build #2742

Merged
merged 4 commits into from
Mar 9, 2019
Merged

Improvements to the conda build #2742

merged 4 commits into from
Mar 9, 2019

Conversation

abergeron
Copy link
Contributor

A collection to small fixes:

  • Add cublas to the cuda builds
  • Reset build numbers following the version bump
  • Some fixes to the build process

I've tried building support for Metal on OS X, but the anaconda compilers are stuck in the 10.9 era before the framework existed so not much luck there. I still want to revisit that later and probably switch to using the system compilers for that.

@yzhliu
Copy link
Member

yzhliu commented Mar 7, 2019

Please request review and satisfy the CI (not sure whether simply re-triggering can work)

@tqchen
Copy link
Member

tqchen commented Mar 8, 2019

CI problem was fixed, do another patch will retrigger

@abergeron abergeron closed this Mar 8, 2019
@abergeron abergeron reopened this Mar 8, 2019
@abergeron
Copy link
Contributor Author

Close/reopen usually retriggers CI for me, but it doesn't appear to work here.

What should I "patch" to trigger it? Or should I just close this one and open a new one with the same commits?

@abergeron
Copy link
Contributor Author

I spoke too soon, the CI is running again.

@abergeron
Copy link
Contributor Author

It seems it crashed in the python tests this time. It might be due to the changes I made in setup.py but that would surprise me.

I have no idea what caused this problem otherwise.

@abergeron
Copy link
Contributor Author

I've removed the changes to setup.py since I don't really need them for this.

This way I can be sure that if the build doesn't pass this time, it's not because I've broken anything.

@abergeron
Copy link
Contributor Author

I might need some help here since I have no idea why the python tests keep crashing. I literally have made no changes outside of the conda packaging so I can't have caused this.

Does anyone have a clue about what is wrong?

@tqchen
Copy link
Member

tqchen commented Mar 9, 2019

Was caused by #2750, should be fixed by now

@tqchen tqchen merged commit 57381b6 into apache:master Mar 9, 2019
@tqchen
Copy link
Member

tqchen commented Mar 9, 2019

I am going to directly merge this in given that the CI error is not related. Thanks @abergeron @yzhliu

wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 9, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants