Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hybrid Script] Misc fixation #2649

Merged
merged 1 commit into from
Feb 22, 2019
Merged

[Hybrid Script] Misc fixation #2649

merged 1 commit into from
Feb 22, 2019

Conversation

were
Copy link
Contributor

@were were commented Feb 22, 2019

3 major things:

  1. Add a symbol table check to avoid id name conflict.
  2. https://discuss.tvm.ai/t/bug-storage-rewrite-doesnt-correctly-handle-local-buffer-allocation/1664/2
    https://discuss.tvm.ai/t/hybrid-variables-on-cuda-should-have-local-scope/1510
    Follow up these issues cast by @vinx13, now hybrid script should inject the thread extent attribute right under the first global scope of the variable and as outside as possible to work around the attached scope problem.
  3. https://discuss.tvm.ai/t/hybrid-script-gpu-schedule/1720
    Follow up the issue cast by @Laurawly, essentially this issue is because TVM has NO abstract to access CUDA registers. If you are writing CUDA, you can just do what it is in normal C++, defining local variables, but in HalideIR there are no variable variables.
    To avoid confusing further users, now compiler will throw error and hint: defining local variables under a bind body is not allowed, and define an array of scratchpad is encouraged.

1 minor thing:
Rename var_decl.py to preprocessor.py

@tqchen tqchen merged commit 76812de into apache:master Feb 22, 2019
@tqchen
Copy link
Member

tqchen commented Feb 22, 2019

Thanks, @were @vinx13 @Laurawly this is merged. @were in the spirit of getting more folks working on the same thing, it will also be great if you can mentor someone to help patch and review hybrid part as well

@yzhliu yzhliu mentioned this pull request Mar 2, 2019
28 tasks
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 9, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants