Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing super() call from refactor #3500

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Removing super() call from refactor #3500

merged 1 commit into from
Sep 19, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Sep 19, 2017 •
edited
Loading

blame #3480

@graceguo-supercat
Copy link

LGTM

@mistercrunch mistercrunch merged commit ae7f163 into apache:master Sep 19, 2017
@mistercrunch mistercrunch deleted the make_not_super branch September 19, 2017 23:41
@coveralls
Copy link

coveralls commented Sep 20, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 69.469% when pulling 1f6e2ac on mistercrunch:make_not_super into ed9f564 on apache:master.

timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request Oct 3, 2017
@mistercrunch @timifasubaa
Removing super() call from refactor (apache#3500)
f764625
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Removing super() call from refactor (apache#3500)
99799d2
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @graceguo-supercat @coveralls