Add metric warning #3499
Merged
Add metric warning #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
michellethomas
force-pushed
the
add_metric_warning
branch
from
3301358
to
5de931f
Compare
|
Looks like there's an alembic issue where db migrations need to be merged. To fix you can run |
michellethomas
force-pushed
the
add_metric_warning
branch
from
5de931f
to
0457761
Compare
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
Oct 3, 2017
* Adding warning text to metrics * Adding javascript tests * Fixing downgrade script for warning_text * Adding merge migration
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Adding warning text to metrics * Adding javascript tests * Fixing downgrade script for warning_text * Adding merge migration
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this issue, I added warning_text to BaseMetric and displayed it in MetricOption.
I added javascript tests, but didn't see changes like this in python tests. Let me know if I should add python tests for this change.
I tested locally:
superset db upgradeadded a warning message on a metric in a sql table
confirmed the message showed up correctly
tested
superset db downgrade