Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Paired t-test table visualization #3473

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Feature: Paired t-test table visualization #3473

merged 2 commits into from
Sep 26, 2017

Conversation

Mogball
Copy link
Contributor

@Mogball Mogball commented Sep 15, 2017 •
edited
Loading

Continuation of #3006

Paired t-test GIF

Features

  • Displays p-values and lift values from Student's t-test between any number of time series
  • Click a row on the table to select the control value
  • Multiple selected metrics give one table each
  • Table columns are sortable
  • Control row to adjust significance level (default 0.05) and decimal precisions
  • Displays statistically significant time series to the selected control

Differences to #3006

  • Does not contain a line graph
  • Supports multiple metrics
  • Each group name is display in its own column

@joshwalters joshwalters mentioned this pull request Sep 15, 2017
Closed
@coveralls
Copy link

coveralls commented Sep 15, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 68.91% when pulling c879427461dc9a6821408180061341dd9a830d3c on Mogball:mogball/feature/paired-ttest-viz into e22aecb on apache:master.

@coveralls
Copy link

coveralls commented Sep 15, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 68.91% when pulling c879427461dc9a6821408180061341dd9a830d3c on Mogball:mogball/feature/paired-ttest-viz into e22aecb on apache:master.

@coveralls
Copy link

coveralls commented Sep 16, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 68.76% when pulling ee871989aeb82ef60c8854101bea621ffaca852e on Mogball:mogball/feature/paired-ttest-viz into e22aecb on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 68.76% when pulling ee871989aeb82ef60c8854101bea621ffaca852e on Mogball:mogball/feature/paired-ttest-viz into e22aecb on apache:master.

@coveralls
Copy link

coveralls commented Sep 16, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 68.91% when pulling 2abc0aec4f00c9c37d03eae66aafbb7128e962fe on Mogball:mogball/feature/paired-ttest-viz into e22aecb on apache:master.

@Mogball Mogball force-pushed the mogball/feature/paired-ttest-viz branch from 2abc0ae to 156cbe7 Compare September 17, 2017 23:46
@coveralls
Copy link

coveralls commented Sep 17, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 68.91% when pulling 156cbe7 on Mogball:mogball/feature/paired-ttest-viz into e22aecb on apache:master.

@Mogball Mogball force-pushed the mogball/feature/paired-ttest-viz branch from a86029e to 5d47cc2 Compare September 18, 2017 20:53
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 69.424% when pulling 5d47cc2b1ecfc2b3355ce2f8378527fc42797c64 on Mogball:mogball/feature/paired-ttest-viz into c3c9ceb on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 69.424% when pulling 5d47cc2b1ecfc2b3355ce2f8378527fc42797c64 on Mogball:mogball/feature/paired-ttest-viz into c3c9ceb on apache:master.

@Mogball Mogball force-pushed the mogball/feature/paired-ttest-viz branch from 5d47cc2 to 8328017 Compare September 18, 2017 21:06
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 69.424% when pulling 8328017c7183de6d129def67e824f5ea3a7ab97b on Mogball:mogball/feature/paired-ttest-viz into c3c9ceb on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 69.424% when pulling 8328017c7183de6d129def67e824f5ea3a7ab97b on Mogball:mogball/feature/paired-ttest-viz into c3c9ceb on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 69.424% when pulling 8328017c7183de6d129def67e824f5ea3a7ab97b on Mogball:mogball/feature/paired-ttest-viz into c3c9ceb on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 69.424% when pulling 8328017c7183de6d129def67e824f5ea3a7ab97b on Mogball:mogball/feature/paired-ttest-viz into c3c9ceb on apache:master.

@Mogball Mogball force-pushed the mogball/feature/paired-ttest-viz branch 4 times, most recently from d637350 to 35b466f Compare September 18, 2017 23:10
@coveralls
Copy link

coveralls commented Sep 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 69.579% when pulling 35b466fa938e3de1a6aef769e7b7902db4728fc5 on Mogball:mogball/feature/paired-ttest-viz into c3c9ceb on apache:master.

joshwalters
joshwalters reviewed Sep 19, 2017
View reviewed changes
Copy link
Contributor

@joshwalters joshwalters left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

70% code coverage, nice!

Edit: Actually just over the hump of 69.5%, but close enough. 😄

superset/assets/visualizations/paired_ttest.jsx Outdated
this.computeTTest(this.state.control);
}

getLiftStatus(row) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some code comments on some of these functions? I get the general idea of what the functions do, but some comments might help with future clarity.

@coveralls
Copy link

coveralls commented Sep 20, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 69.557% when pulling 68c72c9c369b93cd6b0449893fb3518627882566 on Mogball:mogball/feature/paired-ttest-viz into c3c9ceb on apache:master.

@Mogball Mogball force-pushed the mogball/feature/paired-ttest-viz branch from 68c72c9 to 9caafea Compare September 20, 2017 05:12
@coveralls
Copy link

coveralls commented Sep 20, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 69.602% when pulling 9caafeaf0e132070adca264f2d8c0b25ee6767aa on Mogball:mogball/feature/paired-ttest-viz into 1cf634a on apache:master.

@Mogball Mogball force-pushed the mogball/feature/paired-ttest-viz branch 2 times, most recently from 1f476fe to 1680d3b Compare September 20, 2017 19:54
@Mogball Mogball force-pushed the mogball/feature/paired-ttest-viz branch from 1680d3b to aa77088 Compare September 21, 2017 01:48
@Mogball Mogball closed this Sep 21, 2017
@Mogball Mogball reopened this Sep 21, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.523% when pulling aa77088 on Mogball:mogball/feature/paired-ttest-viz into 9af34ba on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 21, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 69.523% when pulling aa77088 on Mogball:mogball/feature/paired-ttest-viz into 9af34ba on apache:master.

@Mogball Mogball closed this Sep 21, 2017
@Mogball Mogball reopened this Sep 21, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.671% when pulling aa77088 on Mogball:mogball/feature/paired-ttest-viz into 9af34ba on apache:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.671% when pulling aa77088 on Mogball:mogball/feature/paired-ttest-viz into 9af34ba on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.671% when pulling aa77088 on Mogball:mogball/feature/paired-ttest-viz into 9af34ba on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.671% when pulling aa77088 on Mogball:mogball/feature/paired-ttest-viz into 9af34ba on apache:master.

@kkalyan
Copy link
Contributor

kkalyan commented Sep 26, 2017

This should be very useful, thanks @Mogball!

@mistercrunch mistercrunch merged commit c629282 into apache:master Sep 26, 2017
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request Oct 3, 2017
@Mogball @timifasubaa
Feature: Paired t-test table visualization (apache#3473)
7ef8b89 
* Feature: paired t-test table viz

* Added unit tests for viz
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@Mogball @michellethomas
Feature: Paired t-test table visualization (apache#3473)
406c708 
* Feature: paired t-test table viz

* Added unit tests for viz
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwalters joshwalters joshwalters left review comments

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mogball @coveralls @kkalyan @joshwalters @mistercrunch