Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sql Lab] Remember Sql Editor window size after user switch tabs #3440

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Sep 8, 2017

I save Editor current height as a state attribute (Redux store "queryEditors"). And the whole redux store will be persisted into localStorage.

@coveralls
Copy link

coveralls commented Sep 9, 2017

Coverage Status

Coverage remained the same at 69.118% when pulling 201cf703afceacc41d60bfe0e3128bc9e515c2b8 on graceguo-supercat:gg-RemeberEditorWindowHeight into 3dfdde1 on apache:master.

@mistercrunch
Copy link
Member

Please rebase

@coveralls
Copy link

coveralls commented Sep 12, 2017

Coverage Status

Coverage remained the same at 69.119% when pulling 20e410a on graceguo-supercat:gg-RemeberEditorWindowHeight into 3c0e85e on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.119% when pulling 20e410a on graceguo-supercat:gg-RemeberEditorWindowHeight into 3c0e85e on apache:master.

@mistercrunch mistercrunch merged commit 2d6b942 into apache:master Sep 12, 2017
@mistercrunch mistercrunch deleted the gg-RemeberEditorWindowHeight branch September 12, 2017 19:06
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants