[explore] improve bubble viz #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistercrunch
commented
Jun 8, 2017
mistercrunch
commented
- allow for custom axis formatters
- reorg the control panels
mistercrunch
force-pushed
the
improve_bubbles
branch
from
2ead0e8
to
6e53a54
Compare
ascott
reviewed
Jun 13, 2017
| } | ||
| if (chart.yAxis !== undefined) { | ||
| chart.yAxis.tickFormat(d3.format('.3s')); | ||
| if (chart.hasOwnProperty('y2Axis')) { |
There was a problem hiding this comment.
i think if (chart.yAxis && chart.yAxis tickFormat) would be less brittle here.
chart.hasOwnProperty('y2Axis') would return true even if the value is undefined, in which case chart.y2Axis.tickFormat() would throw an error. do we always know that chart won't have the key with a value of false or undefined?
ascott
reviewed
Jun 13, 2017
| if (chart.hasOwnProperty('x2Axis')) { | ||
| chart.x2Axis.tickFormat(xAxisFormatter); | ||
| height += 30; | ||
| } | ||
| if (chart.hasOwnProperty('xAxis')) { |
There was a problem hiding this comment.
we should check that chart.xAxis is defined and has the key tickFormat. can we assume that if the key is present that it has a value?
if (chart.xAxis && chart.xAxis tickFormat)
ascott
reviewed
Jun 13, 2017
| } else if (fd.x_axis_format !== undefined) { | ||
| chart.xAxis.tickFormat(timeFormatFactory(fd.x_axis_format)); | ||
| const yAxisFormatter = d3FormatPreset(fd.y_axis_format); | ||
| if (chart.hasOwnProperty('yAxis')) { |
* allow for custom axis formatters * reorg the control panels
mistercrunch
force-pushed
the
improve_bubbles
branch
from
6e53a54
to
a456880
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.