Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reordering of table view columns #7129

Closed
3 tasks done
ju4nlu opened this issue Mar 26, 2019 · 7 comments
Closed
3 tasks done

Allow reordering of table view columns #7129

ju4nlu opened this issue Mar 26, 2019 · 7 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community .pinned Draws attention

Comments

@ju4nlu
Copy link

ju4nlu commented Mar 26, 2019

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version

Commit SHA: b3c4bd95efd5f74e822b7ed7a2db043ba7b8c6cf

Problem

Columns displayed in the table view should be rearrangeable once chosen. They always follow the order in which they were selected, so that if you want the last column to be the first one, you have to remove all the columns and select them again in the correct order. An image of the current column selector is shown below:
image
This issue also happens on the GROUP BY columns.

Possible solution

This could be solved by using the controller used in the Filter Box visualization to select the available filters:
image
In that case, it is possible to rearrange the filters as desired without deleting and adding them again and again.

@michellethomas michellethomas added the enhancement:request Enhancement request submitted by anyone from the community label Mar 29, 2019
@stale
Copy link

stale bot commented May 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 28, 2019
@mistercrunch mistercrunch added the .pinned Draws attention label May 29, 2019
@stale stale bot removed the inactive Inactive for >= 30 days label May 29, 2019
@mistercrunch
Copy link
Member

Ideal would be for someone to contribute the feature in react-select JedWatson/react-select#3223 , please add a "thumbs up" on the issue!

@suddjian
Copy link
Member

suddjian commented Nov 19, 2019

react-select added support for this last month, but it looks like it hasn't been baked into a release yet. I expect it'll probably be in 3.1.0 whenever that is drafted.

@Grace-Dmello
Copy link

Grace-Dmello commented Apr 8, 2020

The react-select has released version 3.1.0 which has this feature. https://react-select.netlify.com/advanced#sortable-multiselect .

However, the react-select library for superset is currently at
"react-select": "1.2.1",

Are there plans to upgrade it to solve the problem?

@ktmud
Copy link
Member

ktmud commented May 8, 2020

This has been implemented in Superset.

#9628

If someone could help testing this PR, that'd be great!

@junlincc
Copy link
Member

🙏@mistercrunch this issue can be closed

@willbarrett
Copy link
Member

Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community .pinned Draws attention
Projects
None yet
Development

No branches or pull requests

8 participants