Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve]: Optimize Docker and Email Settings Page Popup Content #3588

Merged
merged 2 commits into from
Feb 28, 2024
Merged

[Improve]: Optimize Docker and Email Settings Page Popup Content #3588

merged 2 commits into from
Feb 28, 2024

Conversation

wangsizhu0504
Copy link
Member

What changes were proposed in this pull request

Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)
image

@wangsizhu0504
Copy link
Member Author

cc @wolfboys I've improved the form settings in the popup section by getting the configuration fields from the backend and dynamically generating the form items

@wolfboys
Copy link
Member

cc @wolfboys I've improved the form settings in the popup section by getting the configuration fields from the backend and dynamically generating the form items

👌

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit e0455eb into apache:dev-2.1.3 Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants