-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] StarRocks Source & Sink connector #3060
Conversation
import java.util.stream.Stream; | ||
|
||
@Slf4j | ||
public class JdbcStarRocksdbIT extends TestSuiteBase implements TestResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have fixed in new commit.PTAL @hailin0
@@ -110,8 +111,12 @@ private void batchInsertData() { | |||
private void initializeJdbcTable() throws SQLException { | |||
try (Connection connection = DriverManager.getConnection(jdbcUrl, jdbcCase.getUserName(), jdbcCase.getPassword())) { | |||
Statement statement = connection.createStatement(); | |||
String createDatabase = jdbcCase.getInitDatabase(); | |||
String createSource = jdbcCase.getDdlSource(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can include directives to create a database in createSource sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can include directives to create a database in createSource sql
Thank you for your suggestion. I have fixed it
|
||
public class JdbcStarRocksdbIT extends AbstractJdbcIT { | ||
|
||
private static final String DOCKER_IMAGE = "d87904488/starrocks-starter:2.2.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these images be used? It may be more stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these images be used? It may be more stable
https://hub.docker.com/u/starrocks
The official does not provide a docker image to run. The image is used to compile StarRocks refer to https://docs.starrocks.io/zh-cn/latest/administration/Build_in_docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW, Usually, if it uses MySQL's protocol, then we don't need to add any IT or UT for this, it doesn't make much sense. |
thinks,agree with you. |
Purpose of this pull request
add StarRocks Connector
#3018
Description
The MySQL Jdbc connector is reused. StarRocks uses the MySQL protocol syntax.
added all datetype in e2e , refer to https://docs.starrocks.io/zh-cn/2.2/sql-reference/sql-statements/data-types/BIGINT
Check list
New License Guide