Pekko migration #17
Merged
Pekko migration #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seetaramayya
commented
Feb 1, 2023
benchmarks/src/main/scala/org/apache/pekko/kafka/benchmarks/CsvFormatter.scala
Show resolved
Hide resolved
pjfanning
requested changes
Feb 1, 2023
pjfanning
reviewed
Feb 1, 2023
|
Could you look at the broken docs build when you get a chance? Probably mainly due to akka package names still used ins some .md files. |
Seetaramayya
commented
Feb 4, 2023
core/src/main/scala/org/apache/pekko/kafka/ProducerSettings.scala
Outdated
Show resolved
Hide resolved
|
Could you fix the conflict in tests/src/test/scala/akka/kafka/internal/CommitCollectorStageSpec.scala ? You'll need to merge in the recent commit to main branch and then tidy up the conflicted code. This class was probably moved because of a package name change |
|
There are failing integration tests because they try to use the class akka.kafka.tests.CapturingAppender - this class is now presumably renamed (package name change) |
…ala files - Added temporary copy & paste class from alpakka (till migration completes)
Seetaramayya
force-pushed
the
pekko-migration
branch
from
2b1c77e
to
db626e7
Compare
pjfanning
reviewed
Feb 4, 2023
benchmarks/src/it/scala/org/apache/pekko/kafka/benchmarks/AlpakkaCommittableProducer.scala
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Feb 4, 2023
pjfanning
reviewed
Feb 4, 2023
pjfanning
reviewed
Feb 4, 2023
…e_url configuration - Adjusted pekko extref links
|
Merged - @Seetaramayya has an iCLA on file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
pekkolibrariesMigrated from
akkatoorg.apache.pekkopackageInstead of removing dependency on
akka-stream-alpakka-csvlibrary one class needs to be copy pastedIssue#20 is added to handle reference.conf and docs