This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is the plan to apply this convention to all numpy ops? |
@eric-haibin-lin yes. It should also be feasible to throw numpy exception types directly to match the exact behavior in numpy. cc @haojin2 @reminisce |
Nice feature!!! Should we also add the reference of TVM? |
Nice feature! I'm thinking if we can extend this or do similar thing to |
leezu
approved these changes
Dec 31, 2019
apeforest
added a commit
to apeforest/incubator-mxnet
that referenced
this pull request
Jan 16, 2020
apeforest
added a commit
to apeforest/incubator-mxnet
that referenced
this pull request
Jan 16, 2020
apeforest
added a commit
to apeforest/incubator-mxnet
that referenced
this pull request
Jan 19, 2020
apeforest
added a commit
to apeforest/incubator-mxnet
that referenced
this pull request
Jan 19, 2020
apeforest
added a commit
to apeforest/incubator-mxnet
that referenced
this pull request
Jan 20, 2020
szha
added a commit
that referenced
this pull request
Jan 22, 2020
* fix build error due to #17128 * whitelist all *MX* API * Update libmxnet.sym * Update libmxnet.ver Co-authored-by: Sheng Zha <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enable throwing custom error type from backend
With this patch, by prepending error messages with the error type, the frontend will automatically throw exception of that type if the type has been registered.
An example in a check in transpose and its effect
Logging in C++
CHECK_EQ(axes_set.size(), axes.ndim()) << "ValueError: Repeated axis in transpose." << " param.axes = " << param.axes;
Effect
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments