This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[OpPerf] Handle positional arguments #15761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaiBapchya
force-pushed
the
arg_handle_opperf
branch
from
August 6, 2019 01:19
ac8f844
to
7d37257
Compare
apeforest
reviewed
Aug 13, 2019
apeforest
approved these changes
Aug 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after fixing the indent
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* handle args * intermediate, error with getting 2 values for data param for other ops * handle args * None type issue * try * indent fix * lint fix * Trigger notification * Trigger notification bcoz validation/edge passed but shows pending
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15735
Currently, OpPerf utility only takes keyworded arguments **kwargs as argument to run the profiler. It is passed as dictionary value to "inputs"
However, certain functions expect positional arguments (*args) instead of keyworded arguments (**kwargs).
This PR handles that case.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
Tested it with
a. Clone and checkout this branch
b. Build the repo
c. Test both the cases
Without positional arguments
With positional arguments