add crop gluon transform #13679

stu1130 · 2018-12-18T23:21:24Z

Description

Add crop operator and gluon transformer front
support batch input
optimize with openmp

the code change depend on add image resize operator and support batch_size #13611 utitlity function, so will not pass the CI

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@sandeep-krishnamurthy

Roshrini · 2018-12-19T00:25:29Z

@stu1130 Thanks for the contribution. @mxnet-label-bot Add [Gluon, pr-awaiting-review]

* merge NEWS.md from 1.4.x to master * NEWS.md backport from v1.4.x to master

…e#13599) * fallback to dense version for grad(reshape), grad(expand_dims) * add _backward_reshape gpu version * reshape test case comments * fix gpu test * remove mkldnn support for _backward_reshape

* Add Flatten before Gemm * ONNX export test: Allow multiple inputs in forward pass * ONNX export: Test for fully connected

…che#12977) * Adding cpp-package directory to the Doxyfile. Updating the index.md file in c++ api directory. * Updating the link to classes in C++ API to point to correct html file. * Updated the links to use relative paths. * Removed the extra slash character in the url * Excluded the 3rdparty folder as per the review comment.

anirudh2290 · 2018-12-20T22:57:28Z

src/operator/image/crop-inl.h

+    DMLC_DECLARE_FIELD(size)
+    .describe("Size of image for resizing after crop. Could be (width, height) or size");
+    DMLC_DECLARE_FIELD(interp)
+    .describe("Interpolation method for resizing. By default uses bilinear interpolation"


probably need set_default.

anirudh2290 · 2018-12-20T23:43:42Z

src/operator/image/crop.cc

+DMLC_REGISTER_PARAMETER(CropParam);
+
+NNVM_REGISTER_OP(_image_crop)
+.describe(R"code()code" ADD_FILELINE)


please add some usage examples here.

anirudh2290 · 2018-12-20T23:53:57Z

src/operator/image/crop-inl.h

+  if (has_size) {
+    int height;
+    int width;
+    CHECK(param.size.value().ndim() == 1 || param.size.value().ndim() == 2)


why do you need these value() calls ?

to get the value of dmlc::optional

* Added timeout/retry (linear backoff) to docker cache download * Units changed, as time.sleep takes seconds as argument * Improved error handling * Using retry decorator * Added retry decorator to _login_dockerhub method * Fixed wrong import

* Update test_gluon_trainer.py * Update test_gluon_trainer.py * test

* fp16 dot * update mshadow * update mshadow * update mshadow

* fix the quantization script to support python2 * Fix comments, fix similiar issue in imagenet_inference.py

* ONNX test code cleanup * Make tests use the common test case list * Remove import test_cases * Make Gluon backend rep common * Partially enable broadcast tests * Common function to populate tests * Make backend common * test models * Test nodes * ONNX export: Test for fully connected * Edit CI scripts mxnet export test cleanup * Further cleanup backend tests * README * Some corrections * test case format for test_models

* Port of scala infer package to clojure * Add inference examples * Fix project.clj * Update code for integration tests * Address comments and add unit tests * Add specs and simplify interface * Minor nit * Update README

…3728) * tests * remove optimizer and move op to contrib * rename parameter

…e#13654) * Logsoftmax, missing tests * Support multiple outputs in Gluon backendrep * Remove repeated unsqueeze test * Allow multiple output support

* Common test caller * Remove incorrect comment * Make corrections to CI * fix ci script

* ONNX import: Hardmax * Fix lint errors * add github link for issue with reshape

* add clarification for param_dict * more tests for dist kvstore * more unittests * fix a bug * more dist exception test * revert optimizer list * fix bug and comment * fix doc rendering and lint * add invalid sched test * fix website * trigger * update doc

* large op support * replaced size_t with index_t for M, added test case * changed shape

…for original wide_n_deep example (apache#13895) * Add a inference script can provide both accuracy and benchmark result * minor changes * minor fix to use keep similar coding style as other examples * fix typo * remove code redundance and other minor changes * Addressing review comments and minor pylint fix * remove parameter 'accuracy' to make logic simple

…pache#14122)

…#13749) * Adds layout support: mx.sym.Pooling(..., layout='NHWC',...) with tests. * Docs changes * Trigger * Skip NHWC pooling tests on non-cuDNN platforms * Fix pylint NHWC pooling * Fixes from review * Add CuDNNPoolingOp::Supports() in place of Forward()/Backward() bool return. * Add layout support to cpu implementation of Pooling, with tests. * Fix cpplint. * Fix bug in cpu nhwc impl. * Add MXNet CUDA pooling in NWC, NHWC and NDHWC. Turn on 3D cuDNN pooling. Tests. * Add PoolingParam::GetLayout() for better default layout handling. * Fix cpplint. * Throw exception for quantization pooling not NCHW. * Expand nhwc pooling test coverage. * SupportMKLDNNPooling() to examine layout param. * Compare 'std' and 'v1' pooling versions only when op definitions permit. * Add pooling test diagnostic output. * Fix syntax. * Fix pooling FInplaceOption so it can be shared by all implementations. * Add missing param definition. * Fix #if logic. * Temp switch to DickJC123/mshadow: shows effect of half round-to-nearest on cpu. * Move back to dmlc/mshadow.git, now with float->half rounding. * Avoid underflow of lp pooling calc for dtype=float16. * Remove redundant pooling test. * Minor variable naming fixes. * Modify FInplaceOption handling per reviewer comments. Expand testing. * Correct gluon Pooling layout param description. * Correct Symbol Pooling description. * Use 'CHECK(x)' rather than 'if (x) LOG(FATAL)'. * Empty commit to trigger CI.

apache#14130) * Refine runtime feature discovery python API and add documentation to Python API docs * Fix lint * Provide is_enabled method to check if feature is present from string * Refine docs, add is_enabled * Fix encoding * Fix doc * Address CR suggestions * remove index as per CR suggestion * Fix lint * runtime * Fix doc * Add license

* add tutorial * fix the typo

* fixing examples * fixing examples and adding READMEs fixing examples and adding READMEs fixing examples and adding READMEs fixing examples and adding READMEs add missing files fixed some bugs in readmes fixed some bugs in readmes fixed some spelling mistakes update update * removing images and fixing spelling mistakes * removing images and fixing spelling mistakes * updating links * Adding license header * empty commit * Add missing license headers * Adding changes requested by ChaiBapchya

* mp adamw update * Softmax fp16 (apache#201) * softmax for fp16 with fp32 accumulator * return AType in kernel * add dtype * kernel * adamw with nan check * add doc * Revert "Softmax fp16 (apache#201)" This reverts commit 5869e0a. * add test * more test for fp16 * skip update for rescale = 0

stu1130 requested a review from szha as a code owner December 18, 2018 23:21

stu1130 changed the title ~~Add crop gluon transform~~ add crop gluon transform Dec 18, 2018

marcoabreu added Gluon pr-awaiting-review PR is waiting for code review labels Dec 19, 2018

srochel and others added 4 commits December 20, 2018 05:59

NEWS.md backport from v1.4.x to master (apache#13693)

ebd5f68

* merge NEWS.md from 1.4.x to master * NEWS.md backport from v1.4.x to master

Fallback to dense version for grad(reshape), grad(expand_dims) (apach…

59f4395

…e#13599) * fallback to dense version for grad(reshape), grad(expand_dims) * add _backward_reshape gpu version * reshape test case comments * fix gpu test * remove mkldnn support for _backward_reshape

ONNX export: Add Flatten before Gemm (apache#13356)

a4f2ed5

* Add Flatten before Gemm * ONNX export test: Allow multiple inputs in forward pass * ONNX export: Test for fully connected

anirudh2290 reviewed Dec 20, 2018

View reviewed changes

srochel and others added 20 commits December 21, 2018 22:17

Update git clone location to apache github (apache#13706)

3044f8c

address comments

be58c6f

Fix NDArray ToDLPack Bug (apache#13698)

f211588

Added javadocs and improved example instructions (apache#13711)

b018019

Rearrange tests written only for update_on_kvstore = True (apache#13514)

e8e18c9

* Update test_gluon_trainer.py * Update test_gluon_trainer.py * test

Update mshadow to support batch_dot with fp16. (apache#13716)

d18a7d5

* fp16 dot * update mshadow * update mshadow * update mshadow

Fix the quantization script to support Python2 (apache#13700)

48bbac5

* fix the quantization script to support python2 * Fix comments, fix similiar issue in imagenet_inference.py

update social media section (apache#13705)

93b8dc1

script for installing gpu libraries and build tools (apache#13646)

5ea983a

Port of scala infer package to clojure (apache#13595)

b6b197a

* Port of scala infer package to clojure * Add inference examples * Fix project.clj * Update code for integration tests * Address comments and add unit tests * Add specs and simplify interface * Minor nit * Update README

update code owner (apache#13737)

3bfcd93

AdamW operator (Fixing Weight Decay Regularization in Adam) (apache#1…

116d01e

…3728) * tests * remove optimizer and move op to contrib * rename parameter

ONNX import/export: Add missing tests, ONNX export: LogSoftMax (apach…

be3d945

…e#13654) * Logsoftmax, missing tests * Support multiple outputs in Gluon backendrep * Remove repeated unsqueeze test * Allow multiple output support

ONNX test code cleanup - part 2 (apache#13738)

2f202af

* Common test caller * Remove incorrect comment * Make corrections to CI * fix ci script

Update basic_layers.py (apache#13732)

8132a5b

ONNX import: Hardmax (apache#13717)

991bf3b

* ONNX import: Hardmax * Fix lint errors * add github link for issue with reshape

gluon docfix (apache#13631)

9fbd7dd

ChaiBapchya and others added 7 commits February 15, 2019 21:01

Fix nd.pick large array issue (apache#14082)

ed0b791

* large op support * replaced size_t with index_t for M, added test case * changed shape

Added USE_SIGNAL_HANDLER to other Linux builds which didn't had it (a…

059f49f

…pache#14122)

add quantization example to readme (apache#14186)

bada8a1

update raspberry pi install instructions (apache#14172)

af9e3b3

stu1130 reopened this Feb 19, 2019

stu1130 and others added 13 commits February 19, 2019 12:35

Add tutorial on how to use build from source jar (apache#14197)

49c311c

* add tutorial * fix the typo

Scala interpreter instructions (apache#14169)

c45e534

Fix req=null in SliceLikeBackward (apache#14209)

f9c436b

add crop operator and gluon interface

47249be

fix typo & doc

bb517f6

remove the redundant dependency

98f6795

refactor the code to make it more understandable

439afc5

address comments

dc832da

update the crop operator with slice operator

8d54977

fix the resize

aa062b8

fix the conflict

0d741bf

stu1130 requested review from eric-haibin-lin, gigasquid, iblislin, marcoabreu, nswamy, sergeykolychev and yzhliu as code owners February 25, 2019 23:45

stu1130 closed this Feb 25, 2019

anirudhacharya mentioned this pull request Feb 27, 2019

Add Gluon Transformer Crop #14259

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add crop gluon transform #13679

add crop gluon transform #13679

stu1130 commented Dec 18, 2018 •

edited

Loading

Roshrini commented Dec 19, 2018

anirudh2290 Dec 20, 2018

anirudh2290 Dec 20, 2018

anirudh2290 Dec 20, 2018

stu1130 Dec 21, 2018

add crop gluon transform #13679

add crop gluon transform #13679

Conversation

stu1130 commented Dec 18, 2018 • edited Loading

Description

Checklist

Essentials

Changes

Comments

Roshrini commented Dec 19, 2018

anirudh2290 Dec 20, 2018

Choose a reason for hiding this comment

anirudh2290 Dec 20, 2018

Choose a reason for hiding this comment

anirudh2290 Dec 20, 2018

Choose a reason for hiding this comment

stu1130 Dec 21, 2018

Choose a reason for hiding this comment

stu1130 commented Dec 18, 2018 •

edited

Loading