Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-711] Added updated logos to the powered by page and iot select fix #11921

Closed
wants to merge 8 commits into from

Conversation

kpmurali
Copy link
Contributor

@kpmurali kpmurali commented Jul 28, 2018

Description

Updating logos to the powered by page. Added Clojure to the navigation list for APIs.

Checklist

Changes

  • Added updated logos to the powered by page
  • Added Clojure to the navigation list for APIs.
  • IOT selector fix in the install page.

@kpmurali kpmurali requested a review from szha as a code owner July 28, 2018 00:04
@aaronmarkham
Copy link
Contributor

Clojure API preview:
http://54.225.32.15/api/clojure/index.html

Powered By (logos update) preview:
http://54.225.32.15/community/powered_by.html

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The left sidebar could be activated for Clojure, but I already have that in another PR, so this is good to go.

@aaronmarkham
Copy link
Contributor

@gigasquid

@kpmurali kpmurali changed the title [MXNET-711] Added updated logos to the powered by page [MXNET-711] Added updated logos to the powered by page and iot select fix Jul 31, 2018
@aaronmarkham
Copy link
Contributor

@szha Can you take a look. This fixes several things on the site. Adds Clojure and updates logos...

@szha
Copy link
Member

szha commented Aug 3, 2018

image

@szha
Copy link
Member

szha commented Aug 3, 2018

I see the above. I'm on OSX with a Chrome 67.0. and who's powered by who again?

@aaronmarkham
Copy link
Contributor

FYI, I'm working on fixing the footer issue and will break these features out into different PRs.

@anirudh2290 anirudh2290 added Website pr-work-in-progress PR is still work in progress labels Aug 9, 2018
@aaronmarkham
Copy link
Contributor

I looked at this along with SK and we were not able to figure out how to fix the footer properly. Basically, there's some last minute client-side injection going on with the Sphinx theme. It takes the right toolbar content and appends it to the left making for just one Sphinx toolbar. This is done after bootstrap initializes and knows what's on the page. Because that toolbar div is longer now, it didn't push the footer down as expected. We tried a variety of hacks, but basically the Sphinx toolbar "modification" on the left nav pretty much broke things. That would likely need to be undone to fix bootstrap and to fix the footer properly.

@sandeep-krishnamurthy - I saw in the history you might know what's going on here with the Sphinx left side toolbar.

@lebeg
Copy link
Contributor

lebeg commented Sep 3, 2018

The bug visible only for narrow screen:
screen shot 2018-09-03 at 10 50 51

Otherwise it looks alright:
screen shot 2018-09-03 at 10 51 02

@lupesko
Copy link
Contributor

lupesko commented Sep 14, 2018

@kpmurali - are you still actively working on this PR?

@vandanavk
Copy link
Contributor

Is this PR good to go?

@kpmurali @aaronmarkham

@aaronmarkham
Copy link
Contributor

No, the footer is still messed up. I think that this PR should be closed, and an issue created to document that the features (logos) should be resurrected in another PR, along with some workaround or fix for the footer issue.

@vrakesh
Copy link
Contributor

vrakesh commented Oct 9, 2018

@aaronmarkham Is this PR good to close?

@aaronmarkham
Copy link
Contributor

@vrakesh Yes, please close it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants