-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-711] Added updated logos to the powered by page and iot select fix #11921
Conversation
Clojure API preview: Powered By (logos update) preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The left sidebar could be activated for Clojure, but I already have that in another PR, so this is good to go.
@szha Can you take a look. This fixes several things on the site. Adds Clojure and updates logos... |
I see the above. I'm on OSX with a Chrome 67.0. and who's powered by who again? |
FYI, I'm working on fixing the footer issue and will break these features out into different PRs. |
I looked at this along with SK and we were not able to figure out how to fix the footer properly. Basically, there's some last minute client-side injection going on with the Sphinx theme. It takes the right toolbar content and appends it to the left making for just one Sphinx toolbar. This is done after bootstrap initializes and knows what's on the page. Because that toolbar div is longer now, it didn't push the footer down as expected. We tried a variety of hacks, but basically the Sphinx toolbar "modification" on the left nav pretty much broke things. That would likely need to be undone to fix bootstrap and to fix the footer properly. @sandeep-krishnamurthy - I saw in the history you might know what's going on here with the Sphinx left side toolbar. |
@kpmurali - are you still actively working on this PR? |
Is this PR good to go? |
No, the footer is still messed up. I think that this PR should be closed, and an issue created to document that the features (logos) should be resurrected in another PR, along with some workaround or fix for the footer issue. |
@aaronmarkham Is this PR good to close? |
@vrakesh Yes, please close it. |
Description
Updating logos to the powered by page. Added Clojure to the navigation list for APIs.
Checklist
Changes