Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Codecov migration to marketplace app #18421

Closed
thomasrockhu opened this issue May 27, 2020 · 16 comments
Closed

Codecov migration to marketplace app #18421

thomasrockhu opened this issue May 27, 2020 · 16 comments

Comments

@thomasrockhu
Copy link

Hi, Tom from Codecov here.

We noticed that you are using Codecov with fairly high frequency, and we’re so excited to see that! However, because you are not using our app, you may have experienced issues with uploading reports or viewing coverage information. This is due to rate-limiting issues from GitHub.

In order to prevent any future outages, we ask that you move over to our GitHub app integration.

The process is extremely simple and shouldn’t require more than a few clicks, and you should not expect any downtime. By moving to our app, you will no longer need an admin or separate account to manage the relationship with GitHub as the team bot.

Let me know if you have any questions, or if I can help at all with this process.

@leezu
Copy link
Contributor

leezu commented May 27, 2020

cc @marcoabreu

@thomasrockhu
Copy link
Author

Hi @marcoabreu and @leezu, let me know if there's anything I can do to help here.

@leezu
Copy link
Contributor

leezu commented Jun 1, 2020

@thomasrockhu if you can provide more details on the existing setup, that will be helpful. Changing this may require opening a ticket with the Apache Software Foundation Infrastructure Team at https://issues.apache.org/jira/secure/Dashboard.jspa

@thomasrockhu
Copy link
Author

thomasrockhu commented Jun 1, 2020

Hi @leezu, thanks for getting back to me. Regarding Apache Software Foundation Infrastructure Team, we asked a similar repository to move to the integration as well. Since access has been granted, it should only require an admin to add this repository by configuring the integration

@marcoabreu
Copy link
Contributor

Thanks Thomas, I will check with Apache Infra in parallel.

In the meantime, could you elaborate what steps are necessary here to use the ingration? Which part of our setup is exactly being replaced - speak, which changes in our code-base have to be done? What has to be done before we make the switch and what afterwards?

Thanks for assisting us on this matter!

@marcoabreu
Copy link
Contributor

From what I can see, the access for the app has already been granted. What steps are necessary for us to take here now?

@thomasrockhu
Copy link
Author

Hi @marcoabreu, I just checked and everything looks good on our side. Thanks for the quick turnaround here!

@thomasrockhu
Copy link
Author

As far as necessary steps, that's the only one. There is no need for code changes here. If you have been using the team bot, it can now be removed.

@leezu
Copy link
Contributor

leezu commented Jun 2, 2020

@marcoabreu thank you for checking with INFRA. I requested the access for the app as per the suggestions in above linked Apache repo. They stated we don't need an INFRA ticket but simply request the access with github.

@thomasrockhu thank you. So let's close this ticket.

@leezu
Copy link
Contributor

leezu commented Jun 5, 2020

@thomasrockhu previously we only tracked codecov data without exposing it in Github PRs. Our codecov is not stable, and until then we'd like to not expose the data. Enabling the marketplace app lead to the codecov status being shown on every PR and commit. How do we disable this again?

@leezu leezu reopened this Jun 5, 2020
@thomasrockhu
Copy link
Author

Hi @leezu, if you want to disable status checks, you can update the codecov.yml to include

coverage:
  status:
    project: off
    patch: off

Let me know if that works for you!

@leezu
Copy link
Contributor

leezu commented Jun 6, 2020

Thank you @thomasrockhu. We'll work towards making the codecov stable and then re-enable the badges.

@leezu leezu closed this as completed Jun 6, 2020
@thomasrockhu
Copy link
Author

@leezu great, let me know what I can do to help!

@leezu
Copy link
Contributor

leezu commented Jul 20, 2020

@thomasrockhu the codecov.yml stopped working https://github.com/apache/incubator-mxnet/blob/master/.codecov.yml

New PRs show the codecov/project badge again despite we haven't made enough progress on stabilizing the CI to have a stable codecov #18757

@thomasrockhu
Copy link
Author

Hi @leezu, it looks like there are duplicate entries under coverage -> status -> project

coverage:
  status:
    project: off
    patch: off
  precision: 2
  round: down
  range: "70...100"

  status:
    project: yes
    patch: yes
    changes: no

I would recommend removing one of them.

@leezu
Copy link
Contributor

leezu commented Jul 20, 2020

Thank you @thomasrockhu

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants