This image must come from the image package. So can you bring that here? Or we can merge the image first and then you review this const. I'm about to change this versioning/image naming in the operator package to read this info from ENV/Configuration.

Updated to "docker.io/apache/incubator-kie-kogito-db-migrator-tool:latest" as named in DB Migrator Image package here.

For now, unresolving this and reverting to old image for sake of seeing how CI behaves.

I think the dbMigrationStrategy must be added to the DI and JS in this file too.

                      dbMigrationStrategy:
                        default: service
                        description: |-
                          DB Migration approach for service?
                          job: use job based approach
                          service: service itself shall migrate the db
                          none: no db migration needed

@wmedvede Where are DI and JS in this file? Please advise.

same as for the DI, see comment above.

and same comment for default schema name calculation, see: j.GetServiceName()

I believe this calculations are kind of duplicated here:

I think we should explore moving this calculation postgresql.go and reuse.

This file needs tests, the same as we have for other ones.

Hi @wmedvede!
They are included here e.g.

• Service Based Migration
• Job Based Migration

Please let me know if you are referring to something else.

tests please

Important:

Persistence configuration for a service can be taken not only from eg. spec.services.jobsService but also from the SPF global persistence configuration.

see:

https://sonataflow.org/serverlessworkflow/main/cloud/operator/supporting-services.html#common-persistence-configuration

https://sonataflow.org/serverlessworkflow/main/cloud/operator/using-persistence.html#configuring-persistence-using-the-sonataflowplatform-cr

Along this PR, we must consider that potential case too.

I.e, the service don't have "persistence", but the SPF do.

Examples:

	apiVersion: sonataflow.org/v1alpha08
	kind: SonataFlowPlatform
	metadata:
	  name: sonataflow-platform
	spec:
	  services:
	    # no persistence is defined for the DI, it will take it from the SFP if any.
	    # and apply the by default DBMigrationStrategy
	    dataIndex:
	      enabled: true

	    jobService:
	      # The only persistence setting we do is the DBMigrationStrategy
	      # So, the service grabs the persistence configuation from the SPF and the given DBMigrationStrategy
	      # from here.
	      
	      enabled: true
	      persistence:
		dbMigrationStrategy: "job"
	  
	  # global SPF persitence configuration.     
	  persistence:
	    postgresql:
	      secretRef:
		name: postgres-secrets
		userKey: POSTGRESQL_USER
		passwordKey: POSTGRESQL_PASSWORD
	      serviceRef:
		name: postgres
		databaseName: sonataflow

@rhkp take look please and propagate in all places where needed.

@ricardozanini see my considerations for this particular case, where a service takes the persistence from the SPF, but we still can mark at the service level the dbMigrationStrategy

Consider my comments regarding a potential persistence configuration at the SFP level