Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kn-plugin-workflow] Executing kn workflow run creates the container in the background #1647

Open
Tracked by #1583
treblereel opened this issue Nov 27, 2024 · 0 comments · May be fixed by apache/incubator-kie-tools#2778
Assignees
Labels
area:sonataflow Related to CNCF Serverless Workflow Spec and SonataFlow

Comments

@treblereel
Copy link

treblereel commented Nov 27, 2024

When running a workflow application locally using kn workflow run, in previous releases, the behavior kept the bash/terminal session open and user was able to kill it when done with testing. Currently the container of the application is spun in the background and to kill it user need to stop and remove the docker container manually

Benefit is that the container is running in background and as long as user modfiies the project hot reload is doing its job.

At the very least we need to document this and tell user how to stop the container so they are able to work on other project if needed.

Environment

Linux AMD x86_64

Steps to reproduce

  1. Download kn workflow plugin
  2. Run kn workflow create
  3. Run cd new-project
  4. Run kn workflow run

Actual results

The command completes and there is a running podman container in the background.
When users executes Ctrl+C it does nothing.

Expected results

The command does not completes and there is a running podman container asociated with the bash/terminal session. When users executes Ctrl+C in the bash/terminal, it kills the container spun by kn workflow run

Testing

Manual verification of this issue is sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sonataflow Related to CNCF Serverless Workflow Spec and SonataFlow
Projects
None yet
1 participant