Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Support data type extension in graph information base on version attribute of Infos #2

Closed
acezen opened this issue Nov 30, 2022 · 3 comments · Fixed by #27
Closed
Assignees
Labels
enhancement New feature or request

Comments

@acezen
Copy link
Contributor

acezen commented Nov 30, 2022

Is your feature request related to a problem? Please describe.
The version attribute of infos(graph, vertex, edge) now is only a number. Actually it can contain the implicit information that the property data types support with the version. With the version growing, the supported data types could be extended. Likes:
version 1 -> support bool,int32, int64, float, double, string
version 2 -> support bool,int32, int64, float, double, string, date32

Describe the solution you'd like

  • Use string instead of number as version, something like User Agent message of browser.
    version example:
    gar/v1
    gar/v2
    gar/v3 (user_define1, user_define2) # suppose the version 3 or higher support user define type.

  • Add a VersionMeta class to keep record different version supported data types and do the version string parse job.

  • If the yaml contains the data type that the yaml version not support, raise error to user.

@acezen acezen added the enhancement New feature or request label Nov 30, 2022
@acezen acezen self-assigned this Nov 30, 2022
@acezen acezen moved this to Todo in alibaba/GraphAr Dec 7, 2022
@acezen acezen moved this from Todo to In Progress in alibaba/GraphAr Dec 7, 2022
@acezen acezen changed the title Extend the version attribute of yaml to support extending data types support base on version [Feat]: Support data type extension in graph information base on version attribute of Infos Dec 7, 2022
@acezen
Copy link
Contributor Author

acezen commented Dec 7, 2022

@lixueclaire Do you have any supplement or advice to this feature?

@lixueclaire
Copy link
Contributor

Some other works may required for this feature:

  • extend DataType to support user-defined types (record type name as a string)
  • ensure Builder/Writer to raise error when encounter non-supported types

@acezen
Copy link
Contributor Author

acezen commented Dec 7, 2022

Some other works may required for this feature:

  • extend DataType to support user-defined types (record type name as a string)
  • ensure Builder/Writer to raise error when encounter non-supported types

Nice advice, it's very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants