New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Building GraphAr C++ failed on ARM platform #157

Closed

1 task done

acezen opened this issue May 15, 2023 · 2 comments

Closed

1 task done

[Bug]: Building GraphAr C++ failed on ARM platform #157

acezen opened this issue May 15, 2023 · 2 comments

Assignees

Labels

bug

Milestone

Contributor

acezen commented May 15, 2023

Is there an existing issue for this?

I have searched the existing issues

Current Behavior

when building GraphAr C++, got error:

enumerator value ‘-1’ is outside the range of underlying type ‘char’

https://github.com/alibaba/GraphAr/blob/main/cpp/include/gar/writer/arrow_chunk_writer.h#L41-L46

Expected Behavior

Building without error.

Minimal Reproducible Example

cd cpp
cmake ..
make

Environment

Operating system: ARM
GraphAr version: v0.5

Link to GraphAr Logs

No response

Further Information

No response

The text was updated successfully, but these errors were encountered:

acezen self-assigned this

acezen added the bug label

Contributor Author

acezen commented May 16, 2023 •

edited

Loading

hi, @lixueclaire, can you take a look to the issue？, it seems that some ARM architectures would take char as unsigned
https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char

acezen mentioned this issue

[BugFix] Fix compile error on ARM platform #158

Merged

9 tasks

Contributor

lixueclaire commented May 17, 2023

fixed by #158

lixueclaire closed this as completed

acezen added this to the Release v0.6.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment