Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] ProducerGroupConf#equals doesn't work #997

Closed
1 of 2 tasks
kirinzhu opened this issue Jul 6, 2022 · 1 comment
Closed
1 of 2 tasks

[Bug] ProducerGroupConf#equals doesn't work #997

kirinzhu opened this issue Jul 6, 2022 · 1 comment
Assignees
@pkyriakou23
Labels
bug Something isn't working
Milestone
1.6.0

Comments

@kirinzhu
Copy link
Contributor

kirinzhu commented Jul 6, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Mac

EventMesh version

master

What happened

This code compares java.lang.String objects for reference equality using the == or != operators instead of equals()

How to reproduce

In module eventmesh-runtime
In class org.apache.eventmesh.runtime.core.consumergroup.ProducerGroupConf
In method org.apache.eventmesh.runtime.core.consumergroup.ProducerGroupConf.equals(Object)
In [line 50]

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@kirinzhu kirinzhu added the bug Something isn't working label Jul 6, 2022
@Alonexc Alonexc mentioned this issue Jul 12, 2022
Open
@pkyriakou23
Copy link
Contributor

pkyriakou23 commented Jul 15, 2022 •
edited
Loading

hi, i am curious all i have to do is to change return groupName == that.groupName; to return groupName.equals(that.groupName); ?

@pkyriakou23 pkyriakou23 mentioned this issue Jul 15, 2022
Merged
@ruanwenjun ruanwenjun changed the title [Bug] Comparison of String objects using == or != instead of equals() [Bug] ProducerGroupConf#equals doesn't work Jul 18, 2022
xwm1992 added a commit that referenced this issue Aug 4, 2022
@xwm1992
Merge pull request #1025 from pkyriakou23/fixing_issue997
ab19338 
[ISSUE #997] [Bug] ProducerGroupConf equals method doesn't work
close #997
@xwm1992 xwm1992 added this to the 1.6.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkyriakou23 pkyriakou23

Labels
bug Something isn't working
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@xwm1992 @pkyriakou23 @kirinzhu