[Enhancement] Some optimizations for collections

[Alonexc]

Search before asking

• I had searched in the issues and found no similar issues.

Enhancement Request

located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/recommend/EventMeshRecommendImpl.java line 114,116,126,201,207

Describe the solution you'd like

1. Iteration call can be replaced with parametrized constructor call
2. Collections.sort could be replaced with List.sort
   reference:
   

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[mvadharia]

Hi @xwm1992 @Alonexc , seems like this issue has already fixed and code has been updated.
But I do have a suggestion on EventMeshRecommendImpl line 172 in recommendProxy() method, instead of looping through keys, retainAll method of Set after retrieving keySet() from Map, can be used to check if there exists a key in clientDistributionMap but not in eventMeshMap and vice versa if required insteading of looping through entire keySet.
I can raise PR for the improvement I mentioned and we can close this issue once done.

[Alonexc]

Hi @xwm1992 @Alonexc , seems like this issue has already fixed and code has been updated. But I do have a suggestion on EventMeshRecommendImpl line 172 in recommendProxy() method, instead of looping through keys, retainAll method of Set after retrieving keySet() from Map, can be used to check if there exists a key in clientDistributionMap but not in eventMeshMap and vice versa if required insteading of looping through entire keySet. I can raise PR for the improvement I mentioned and we can close this issue once done.

@mvadharia Ok, I see that it has been fixed and I will close the issue.