Skip to content

[Bug] The result of validate target url method is opposite in http protocol #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
zmt-Eason opened this issue Jul 22, 2022 · 1 comment
Closed
2 tasks done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@zmt-Eason
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Windows

EventMesh version

1.4.0

What happened

image
This method should return false when target url in blacklist, which now return true.

How to reproduce

Target url not in blacklist ,but would receive error response hint invalid url when subscribe.

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zmt-Eason zmt-Eason added the bug Something isn't working label Jul 22, 2022
@github-actions
Copy link
Contributor

Welcome to the Apache EventMesh (incubating) community!!
We are glad that you are contributing by opening this issue. :D

Please make sure to include all the relevant context.
We will be here shortly.

If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on contributing to EventMesh.

Want to get closer to the community?

WeChat Group:
wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

xwm1992 added a commit that referenced this issue Aug 4, 2022
[ISSUE #1038] fix valid url bug
close #1038
@xwm1992 xwm1992 added this to the 1.6.0 milestone Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants