Skip to content

IGNITE-13680 maxSwappiness declared as int in suggestions #8503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

IGNITE-13680 maxSwappiness declared as int in suggestions #8503

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9a42707
IGNITE-13680 maxSwappiness declared as int in suggestions
Nov 27, 2020
726d17b
IGNITE-13680 checkstyle amendments applied in OsConfigurationSuggesti…
nyshubin Nov 27, 2020
2a2d052
IGNITE-13680 Linux added to the systems list in OsConfigurationSugges…
nyshubin Dec 6, 2020
055e768
IGNITE-13680 check isRedHat removed in OsConfigurationSuggestions.java
nyshubin Dec 9, 2020
f6d8bd1
IGNITE-13680 Cast exp and val to int and replaced .equals comparison …
nyshubin Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions ...core/src/main/java/org/apache/ignite/internal/suggestions/OsConfigurationSuggestions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ public static synchronized List<String> getSuggestions() {
List<String> suggestions = new ArrayList<>();

if (U.isRedHat()) {
String value;
String expected = "500";
String val;
String exp = "500";

boolean dwcParamFlag = (value = readVmParam(DIRTY_WRITEBACK_CENTISECS)) != null && !value.equals(expected);
boolean decParamFlag = (value = readVmParam(DIRTY_EXPIRE_CENTISECS)) != null && !value.equals(expected);
boolean dwcParamFlag = (val = readVmParam(DIRTY_WRITEBACK_CENTISECS)) != null && !val.equals(exp);
boolean decParamFlag = (val = readVmParam(DIRTY_EXPIRE_CENTISECS)) != null && !val.equals(exp);

if (dwcParamFlag || decParamFlag)
suggestions.add(String.format("Speed up flushing of dirty pages by OS " +
Expand All @@ -74,28 +74,28 @@ public static synchronized List<String> getSuggestions() {
(dwcParamFlag && decParamFlag ? " and " : ""),
(decParamFlag ? "vm." + DIRTY_EXPIRE_CENTISECS : ""),
(dwcParamFlag && decParamFlag ? "s" : ""),
expected));
exp));

if ((value = readVmParam(SWAPPINESS)) != null) {
if ((val = readVmParam(SWAPPINESS)) != null) {
try {
double maxSwappiness = 10.0;
int maxSwappiness = 10;

if (Float.parseFloat(value) > maxSwappiness)
suggestions.add(String.format("Reduce pages swapping ratio (set vm.%s=%f or less)", SWAPPINESS,
if (Integer.parseInt(val) > maxSwappiness)
suggestions.add(String.format("Reduce pages swapping ratio (set vm.%s=%d or less)", SWAPPINESS,
maxSwappiness));
}
catch (NumberFormatException ignored) {
// OS param not parsable as a number
}
}

if ((value = readVmParam(ZONE_RECLAIM_MODE)) != null && !value.equals(expected = "0"))
if ((val = readVmParam(ZONE_RECLAIM_MODE)) != null && !val.equals(exp = "0"))
suggestions.add(String.format("Disable NUMA memory reclaim (set vm.%s=%s)", ZONE_RECLAIM_MODE,
expected));
exp));

if ((value = readVmParam(EXTRA_FREE_KBYTES)) != null && !value.equals(expected = "1240000"))
if ((val = readVmParam(EXTRA_FREE_KBYTES)) != null && !val.equals(exp = "1240000"))
suggestions.add(String.format("Avoid direct reclaim and page allocation failures (set vm.%s=%s)",
EXTRA_FREE_KBYTES, expected));
EXTRA_FREE_KBYTES, exp));
}

return suggestions;
Expand Down