From f82d830e06685c0f905690ac41fb071b33bcb22e Mon Sep 17 00:00:00 2001 From: xzw Date: Fri, 14 Oct 2022 09:38:52 +0800 Subject: [PATCH 1/2] Fixed return format and javadoc --- .../main/java/org/apache/iceberg/transforms/Transforms.java | 6 +++--- format/spec.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/api/src/main/java/org/apache/iceberg/transforms/Transforms.java b/api/src/main/java/org/apache/iceberg/transforms/Transforms.java index 0a0c70b74604..a91505f1958d 100644 --- a/api/src/main/java/org/apache/iceberg/transforms/Transforms.java +++ b/api/src/main/java/org/apache/iceberg/transforms/Transforms.java @@ -245,7 +245,7 @@ public static Transform year() { * Returns a year {@link Transform} for date or timestamp types. * * @param Java type passed to this transform - * @return a year transform + * @return a month transform */ public static Transform month() { return Months.get(); @@ -255,7 +255,7 @@ public static Transform month() { * Returns a year {@link Transform} for date or timestamp types. * * @param Java type passed to this transform - * @return a year transform + * @return a day transform */ public static Transform day() { return Days.get(); @@ -265,7 +265,7 @@ public static Transform day() { * Returns a year {@link Transform} for date or timestamp types. * * @param Java type passed to this transform - * @return a year transform + * @return a hour transform */ public static Transform hour() { return Hours.get(); diff --git a/format/spec.md b/format/spec.md index c8bcf52e3bb6..96b335ffbb76 100644 --- a/format/spec.md +++ b/format/spec.md @@ -311,7 +311,7 @@ Partition specs capture the transform from table data to partition values. This | **`truncate[W]`** | Value truncated to width `W` (see below) | `int`, `long`, `decimal`, `string` | Source type | | **`year`** | Extract a date or timestamp year, as years from 1970 | `date`, `timestamp`, `timestamptz` | `int` | | **`month`** | Extract a date or timestamp month, as months from 1970-01-01 | `date`, `timestamp`, `timestamptz` | `int` | -| **`day`** | Extract a date or timestamp day, as days from 1970-01-01 | `date`, `timestamp`, `timestamptz` | `date` | +| **`day`** | Extract a date or timestamp day, as days from 1970-01-01 | `date`, `timestamp`, `timestamptz` | `int` | | **`hour`** | Extract a timestamp hour, as hours from 1970-01-01 00:00:00 | `timestamp`, `timestamptz` | `int` | | **`void`** | Always produces `null` | Any | Source type or `int` | From f8388b306b4621c387ed1d0197e6b3b29cb3eb1f Mon Sep 17 00:00:00 2001 From: xzw Date: Fri, 14 Oct 2022 15:35:31 +0800 Subject: [PATCH 2/2] Fixed return format and javadoc --- .../java/org/apache/iceberg/transforms/Transforms.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/api/src/main/java/org/apache/iceberg/transforms/Transforms.java b/api/src/main/java/org/apache/iceberg/transforms/Transforms.java index a91505f1958d..9f23e742ec57 100644 --- a/api/src/main/java/org/apache/iceberg/transforms/Transforms.java +++ b/api/src/main/java/org/apache/iceberg/transforms/Transforms.java @@ -242,7 +242,7 @@ public static Transform year() { } /** - * Returns a year {@link Transform} for date or timestamp types. + * Returns a month {@link Transform} for date or timestamp types. * * @param Java type passed to this transform * @return a month transform @@ -252,7 +252,7 @@ public static Transform month() { } /** - * Returns a year {@link Transform} for date or timestamp types. + * Returns a day {@link Transform} for date or timestamp types. * * @param Java type passed to this transform * @return a day transform @@ -262,10 +262,10 @@ public static Transform day() { } /** - * Returns a year {@link Transform} for date or timestamp types. + * Returns an hour {@link Transform} for date or timestamp types. * * @param Java type passed to this transform - * @return a hour transform + * @return an hour transform */ public static Transform hour() { return Hours.get();