iss1980 a special close flag added to indicate that the writer is closed#2001
Merged
rdblue merged 5 commits intoapache:masterfrom Jan 5, 2021
Merged
iss1980 a special close flag added to indicate that the writer is closed#2001rdblue merged 5 commits intoapache:masterfrom
rdblue merged 5 commits intoapache:masterfrom
Conversation
dmgcodevil
changed the title
rdblue
reviewed
Dec 29, 2020
parquet/src/test/java/org/apache/iceberg/parquet/ParquetWritingTestUtils.java
Show resolved
Hide resolved
rdblue
reviewed
Dec 29, 2020
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 29, 2020
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks for fixing this, @dmgcodevil! Looks close, just a few things to update. |
rdblue
reviewed
Jan 4, 2021
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jan 4, 2021
rdblue
reviewed
Jan 4, 2021
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jan 4, 2021
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jan 5, 2021
rdblue
reviewed
Jan 5, 2021
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jan 5, 2021
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
Outdated
Show resolved
Hide resolved
rdblue
approved these changes
Jan 5, 2021
Contributor
|
Thanks @dmgcodevil! I merged this. It should be in the 0.11.0 release. |
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/iceberg
that referenced
this pull request
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a fix for iss1980