Skip to content

API: Fix timestamp(9) with identity partitioning. #13746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielcweeks merged 2 commits into from
Aug 6, 2025
Merged

API: Fix timestamp(9) with identity partitioning. #13746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd692a3
API: Fix timestamp(9) with identity partitioning.
rdblue Aug 5, 2025
5524323
Apply spotless.
rdblue Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions api/src/main/java/org/apache/iceberg/transforms/Identity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,7 @@ public UnboundPredicate<T> projectStrict(String name, BoundPredicate<T> predicat
if (predicate.isUnaryPredicate()) {
return Expressions.predicate(predicate.op(), name);
} else if (predicate.isLiteralPredicate()) {
return Expressions.predicate(
predicate.op(), name, predicate.asLiteralPredicate().literal().value());
return Expressions.predicate(predicate.op(), name, predicate.asLiteralPredicate().literal());
} else if (predicate.isSetPredicate()) {
return Expressions.predicate(predicate.op(), name, predicate.asSetPredicate().literalSet());
}
Expand Down
23 changes: 23 additions & 0 deletions api/src/test/java/org/apache/iceberg/transforms/TestProjection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.apache.iceberg.PartitionSpec;
import org.apache.iceberg.Schema;
import org.apache.iceberg.exceptions.ValidationException;
import org.apache.iceberg.expressions.Binder;
import org.apache.iceberg.expressions.BoundPredicate;
import org.apache.iceberg.expressions.Expression;
import org.apache.iceberg.expressions.Expressions;
Expand Down Expand Up @@ -90,6 +91,28 @@ public void testIdentityProjection() {
}
}

@Test
public void testTimestampNanosIdentityProjection() {
org.apache.iceberg.Schema schema =
new org.apache.iceberg.Schema(
Comment on lines +96 to +97
Copy link
Contributor

@ebyhr ebyhr Aug 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The package org.apache.iceberg looks redundant as this class already imports Schema.

Types.NestedField.required(1, "id", Types.LongType.get()),
Types.NestedField.optional(2, "ts", Types.TimestampNanoType.withoutZone()));

PartitionSpec spec = PartitionSpec.builderFor(schema).identity("ts").build();

Expression expr = Expressions.equal("ts", "2022-07-26T12:13:14.123456789");
Expression projected = Projections.inclusive(spec).project(expr);

Expression bound = Binder.bind(schema.asStruct(), projected, false);

assertThat(bound).isInstanceOf(BoundPredicate.class);
BoundPredicate<?> boundPredicate = (BoundPredicate<?>) bound;
assertThat(boundPredicate.isLiteralPredicate()).isTrue();
assertThat(boundPredicate.asLiteralPredicate().literal().value())
.as("Should bind to the correct value")
.isEqualTo(1658837594123456789L);
}

@Test
public void testCaseInsensitiveIdentityProjection() {
List<UnboundPredicate<?>> predicates =
Expand Down