From b4e0dc4fe1b25cf5646e6c6ddf63b9ee0024308e Mon Sep 17 00:00:00 2001 From: Yuya Ebihara Date: Wed, 19 Feb 2025 08:51:19 +0900 Subject: [PATCH] Parquet: Fix errorprone warning --- baseline.gradle | 2 ++ parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/baseline.gradle b/baseline.gradle index 07889d4e348c..25dab14afb70 100644 --- a/baseline.gradle +++ b/baseline.gradle @@ -153,9 +153,11 @@ subprojects { '-Xep:UnicodeEscape:ERROR', // Palantir's UnnecessarilyQualified may throw during analysis '-Xep:UnnecessarilyQualified:OFF', + '-Xep:UnnecessaryLambdaArgumentParentheses:ERROR', '-Xep:UnnecessaryLongToIntConversion:ERROR', '-Xep:UnnecessaryMethodReference:ERROR', '-Xep:UnusedMethod:ERROR', + '-Xep:UnusedTypeParameter:ERROR', '-Xep:UnusedVariable:ERROR', '-Xep:UseEnumSwitch:ERROR', ) diff --git a/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java b/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java index 7677a53de0c1..d8ecd0d8a3a7 100644 --- a/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java +++ b/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java @@ -283,7 +283,7 @@ private WriteBuilder createContextFunc( return this; } - private void setBloomFilterConfig( + private void setBloomFilterConfig( Context context, MessageType parquetSchema, BiConsumer withBloomFilterEnabled, @@ -1291,7 +1291,7 @@ public CloseableIterable build() { } else { Function> readBuilder = readerFuncWithSchema != null - ? (fileType) -> readerFuncWithSchema.apply(schema, fileType) + ? fileType -> readerFuncWithSchema.apply(schema, fileType) : readerFunc; return new org.apache.iceberg.parquet.ParquetReader<>( file, schema, options, readBuilder, mapping, filter, reuseContainers, caseSensitive);