From e075805d16c72499bcf8af1b05495e0af65741e9 Mon Sep 17 00:00:00 2001 From: Munendra S N Date: Sun, 4 Aug 2024 12:23:59 +0530 Subject: [PATCH 1/5] Spec: Add expiry time config to REST table load --- open-api/rest-catalog-open-api.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/open-api/rest-catalog-open-api.yaml b/open-api/rest-catalog-open-api.yaml index 661af11efc4b..5a5157c5b444 100644 --- a/open-api/rest-catalog-open-api.yaml +++ b/open-api/rest-catalog-open-api.yaml @@ -2773,6 +2773,7 @@ components: - `s3.secret-access-key`: secret for credentials that provide access to data in S3 - `s3.session-token`: if present, this value should be used for as the session token - `s3.remote-signing-enabled`: if `true` remote signing should be performed as described in the `s3-signer-open-api.yaml` specification + - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials will expire. type: object required: - metadata From f85e69562e577395989514c23822a39effbc7ea3 Mon Sep 17 00:00:00 2001 From: Munendra S N Date: Sun, 4 Aug 2024 12:49:19 +0530 Subject: [PATCH 2/5] fix build failure --- open-api/rest-catalog-open-api.py | 1 + open-api/rest-catalog-open-api.yaml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/open-api/rest-catalog-open-api.py b/open-api/rest-catalog-open-api.py index 56212f1ac0b5..75d0b1495593 100644 --- a/open-api/rest-catalog-open-api.py +++ b/open-api/rest-catalog-open-api.py @@ -1112,6 +1112,7 @@ class LoadTableResult(BaseModel): - `s3.secret-access-key`: secret for credentials that provide access to data in S3 - `s3.session-token`: if present, this value should be used for as the session token - `s3.remote-signing-enabled`: if `true` remote signing should be performed as described in the `s3-signer-open-api.yaml` specification + - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials would expire """ diff --git a/open-api/rest-catalog-open-api.yaml b/open-api/rest-catalog-open-api.yaml index 5a5157c5b444..208fcbec02a3 100644 --- a/open-api/rest-catalog-open-api.yaml +++ b/open-api/rest-catalog-open-api.yaml @@ -2773,7 +2773,7 @@ components: - `s3.secret-access-key`: secret for credentials that provide access to data in S3 - `s3.session-token`: if present, this value should be used for as the session token - `s3.remote-signing-enabled`: if `true` remote signing should be performed as described in the `s3-signer-open-api.yaml` specification - - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials will expire. + - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials would expire type: object required: - metadata From 858e4a03639c23e8cc432582d09999d78a8933b4 Mon Sep 17 00:00:00 2001 From: Munendra S N Date: Mon, 5 Aug 2024 16:01:16 +0530 Subject: [PATCH 3/5] move the config property to general configuration --- open-api/rest-catalog-open-api.py | 2 +- open-api/rest-catalog-open-api.yaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/open-api/rest-catalog-open-api.py b/open-api/rest-catalog-open-api.py index 75d0b1495593..ebbf7889976c 100644 --- a/open-api/rest-catalog-open-api.py +++ b/open-api/rest-catalog-open-api.py @@ -1103,6 +1103,7 @@ class LoadTableResult(BaseModel): ## General Configurations - `token`: Authorization bearer token to use for table requests if OAuth2 security is enabled + - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials for storage(AWS S3/Azure/), specified in config would expire ## AWS Configurations @@ -1112,7 +1113,6 @@ class LoadTableResult(BaseModel): - `s3.secret-access-key`: secret for credentials that provide access to data in S3 - `s3.session-token`: if present, this value should be used for as the session token - `s3.remote-signing-enabled`: if `true` remote signing should be performed as described in the `s3-signer-open-api.yaml` specification - - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials would expire """ diff --git a/open-api/rest-catalog-open-api.yaml b/open-api/rest-catalog-open-api.yaml index 208fcbec02a3..39ce976ee7cd 100644 --- a/open-api/rest-catalog-open-api.yaml +++ b/open-api/rest-catalog-open-api.yaml @@ -2763,7 +2763,8 @@ components: ## General Configurations - - `token`: Authorization bearer token to use for table requests if OAuth2 security is enabled + - `token`: Authorization bearer token to use for table requests if OAuth2 security is enabled + - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials for storage(AWS S3/Azure/), specified in config would expire ## AWS Configurations @@ -2773,7 +2774,6 @@ components: - `s3.secret-access-key`: secret for credentials that provide access to data in S3 - `s3.session-token`: if present, this value should be used for as the session token - `s3.remote-signing-enabled`: if `true` remote signing should be performed as described in the `s3-signer-open-api.yaml` specification - - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials would expire type: object required: - metadata From b83ee8b7d0f8808ea32c0f515ea6a8088616705c Mon Sep 17 00:00:00 2001 From: S N Munendra <9696252+munendrasn@users.noreply.github.com> Date: Thu, 10 Oct 2024 19:43:03 +0530 Subject: [PATCH 4/5] Update open-api/rest-catalog-open-api.yaml Co-authored-by: Alexandre Dutra --- open-api/rest-catalog-open-api.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/open-api/rest-catalog-open-api.yaml b/open-api/rest-catalog-open-api.yaml index 39ce976ee7cd..5fc7c8c718f7 100644 --- a/open-api/rest-catalog-open-api.yaml +++ b/open-api/rest-catalog-open-api.yaml @@ -2764,7 +2764,7 @@ components: ## General Configurations - `token`: Authorization bearer token to use for table requests if OAuth2 security is enabled - - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials for storage(AWS S3/Azure/), specified in config would expire + - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials for storage(AWS S3/Azure/GCP), specified in config would expire ## AWS Configurations From 43798569d010826882c0de0fbbaa96a1b520bc55 Mon Sep 17 00:00:00 2001 From: S N Munendra <9696252+munendrasn@users.noreply.github.com> Date: Thu, 10 Oct 2024 19:43:53 +0530 Subject: [PATCH 5/5] Update rest-catalog-open-api.py --- open-api/rest-catalog-open-api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/open-api/rest-catalog-open-api.py b/open-api/rest-catalog-open-api.py index ebbf7889976c..102597ab6e88 100644 --- a/open-api/rest-catalog-open-api.py +++ b/open-api/rest-catalog-open-api.py @@ -1103,7 +1103,7 @@ class LoadTableResult(BaseModel): ## General Configurations - `token`: Authorization bearer token to use for table requests if OAuth2 security is enabled - - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials for storage(AWS S3/Azure/), specified in config would expire + - `expires-at-ms`: if present, specifies timestamp in milliseconds when credentials for storage(AWS S3/Azure/GCP), specified in config would expire ## AWS Configurations