Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate file path creation to LocationProvider #6809

Closed
jackye1995 opened this issue Feb 11, 2023 · 3 comments
Closed

Consolidate file path creation to LocationProvider #6809

jackye1995 opened this issue Feb 11, 2023 · 3 comments
Labels

Comments

@jackye1995
Copy link
Contributor

Feature Request / Improvement

from #6772 (comment), also copied here:

We have different places for creating file path names,

  • LocationProvider for data files
  • TableOperations.metadataFileLocation for manifests and manifest lists
  • catalog specific impl for metadata file location (e.g. BaseMetastoreTableOperations.newTableMetadataFilePath)

We should consolidate all the file path creations to LocationProvider if possible. Any thoughts? @rdblue @nastra @RussellSpitzer

This would also help us enforce things like object storage mode to not just data files but also metadata files.

Query engine

None

@youngxinler
Copy link
Contributor

If this PR was added, I think it would be better to declare it to tell users that all added paths should follow POSIX compliant paths? Even though we have normalized it internally.

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

@github-actions github-actions bot added the stale label Aug 14, 2023
Copy link

github-actions bot commented Jan 9, 2024

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants