Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glue.endpoint config implementation? #414

Closed
sebpretzer opened this issue Feb 12, 2024 · 1 comment · Fixed by #920
Closed

glue.endpoint config implementation? #414

sebpretzer opened this issue Feb 12, 2024 · 1 comment · Fixed by #920

Comments

@sebpretzer
Copy link
Contributor

Feature Request / Improvement

@HonahX @Fokko I was wondering if the glue.endpoint config variable could be implemented? Similar to how s3.endpoint has already been implemented in pyiceberg, and how glue.endpoint has been implemented in iceberg. I am trying to integrate my tests completely with a moto server, but that cannot be done without routing glue calls to a separate endpoint afaik. I have a hack in my codebase for now, so this request is not urgent.

I think this would mainly impact the boto glue client (plus tests and documentation). If that is the extent of changes, I am happy taking a crack at implementing it.

I know you are all mid-release, and there are other glue namespaced config variables that you may want to do all at the same time, so I leave it to you if this is something worth pursuing.

Thanks!

@Fokko
Copy link
Contributor

Fokko commented Feb 12, 2024

Hey @sebpretzer thanks for reaching out! I think it would be a good addition. We didn't port all the configuration upfront to make sure that we only port the relevant keys. It would be great if you could provide a PR. Feel free to tag me there.

@sungwy sungwy added this to the PyIceberg 0.7.0 release milestone Feb 13, 2024
@HonahX HonahX linked a pull request Jul 12, 2024 that will close this issue
@HonahX HonahX closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants