From 62d228369cc95f58f47e0b097eec8b0deee46662 Mon Sep 17 00:00:00 2001 From: KnightChess <981159963@qq.com> Date: Thu, 21 Apr 2022 13:33:22 +0800 Subject: [PATCH] [MINOR] update alter rename command class type for pattern matching --- .../sql/hudi/command/AlterHoodieTableRenameCommand.scala | 6 +++--- .../org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala | 2 +- .../org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala b/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala index c7b5bdc202f65..094106c8d06d8 100644 --- a/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala +++ b/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala @@ -27,11 +27,11 @@ import org.apache.spark.sql.execution.command.AlterTableRenameCommand /** * Command for alter hudi table's table name. */ -class AlterHoodieTableRenameCommand( +case class AlterHoodieTableRenameCommand( oldName: TableIdentifier, newName: TableIdentifier, isView: Boolean) - extends AlterTableRenameCommand(oldName, newName, isView) { + extends HoodieLeafRunnableCommand { override def run(sparkSession: SparkSession): Seq[Row] = { if (newName != oldName) { @@ -45,7 +45,7 @@ class AlterHoodieTableRenameCommand( .initTable(hadoopConf, hoodieCatalogTable.tableLocation) // Call AlterTableRenameCommand#run to rename table in meta. - super.run(sparkSession) + AlterTableRenameCommand(oldName, newName, isView).run(sparkSession) } Seq.empty[Row] } diff --git a/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala b/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala index d3d191734eacb..dcacbef3a26fa 100644 --- a/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala +++ b/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala @@ -526,7 +526,7 @@ case class HoodiePostAnalysisRule(sparkSession: SparkSession) extends Rule[Logic // Rewrite the AlterTableRenameCommand to AlterHoodieTableRenameCommand case AlterTableRenameCommand(oldName, newName, isView) if !isView && sparkAdapter.isHoodieTable(oldName, sparkSession) => - new AlterHoodieTableRenameCommand(oldName, newName, isView) + AlterHoodieTableRenameCommand(oldName, newName, isView) // Rewrite the AlterTableChangeColumnCommand to AlterHoodieTableChangeColumnCommand case AlterTableChangeColumnCommand(tableName, columnName, newColumn) if sparkAdapter.isHoodieTable(tableName, sparkSession) => diff --git a/hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala b/hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala index d9858b69cc081..82ea356215ca5 100644 --- a/hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala +++ b/hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala @@ -139,7 +139,7 @@ class HoodieCatalog extends DelegatingCatalogExtension override def renameTable(oldIdent: Identifier, newIdent: Identifier): Unit = { loadTable(oldIdent) match { case _: HoodieInternalV2Table => - new AlterHoodieTableRenameCommand(oldIdent.asTableIdentifier, newIdent.asTableIdentifier, false).run(spark) + AlterHoodieTableRenameCommand(oldIdent.asTableIdentifier, newIdent.asTableIdentifier, false).run(spark) case _ => super.renameTable(oldIdent, newIdent) } }