From 704e852218f48db72161fb658fe6cd8e3091fdf1 Mon Sep 17 00:00:00 2001 From: yuezhang Date: Mon, 24 Jan 2022 13:46:20 +0800 Subject: [PATCH] typo fix --- .../hudi/metadata/HoodieBackedTableMetadataWriter.java | 2 +- .../org/apache/hudi/metadata/BaseTableMetadata.java | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java index 32f05cbad870c..f3225a3a1adf6 100644 --- a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java +++ b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java @@ -535,7 +535,7 @@ private List listAllPartitions(HoodieTableMetaClient datasetMetaC * All FileGroups for a given metadata partition has a fixed prefix as per the {@link MetadataPartitionType#getFileIdPrefix()}. * Each file group is suffixed with 4 digits with increments of 1 starting with 0000. * - * Lets say we configure 10 file groups for record level index partittion, and prefix as "record-index-bucket-" + * Lets say we configure 10 file groups for record level index partition, and prefix as "record-index-bucket-" * File groups will be named as : * record-index-bucket-0000, .... -> ..., record-index-bucket-0009 */ diff --git a/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java b/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java index ccd421e677651..5373e9860b5e7 100644 --- a/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java +++ b/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java @@ -231,18 +231,18 @@ Map fetchAllFilesInPartitionPaths(List partitionPath } /** - * May be handle spurious deletes. Depending on config, throw an exception or log a warn msg. + * Maybe handle spurious deletes. Depending on config, throw an exception or log a warn msg. * @param hoodieRecord instance of {@link HoodieRecord} of interest. * @param partitionName partition name of interest. */ private void mayBeHandleSpuriousDeletes(Option> hoodieRecord, String partitionName) { if (!hoodieRecord.get().getData().getDeletions().isEmpty()) { - if (!metadataConfig.ignoreSpuriousDeletes()) { + if (metadataConfig.ignoreSpuriousDeletes()) { + LOG.warn("Metadata record for " + partitionName + " encountered some files to be deleted which was not added before. " + + "Ignoring the spurious deletes as the `" + HoodieMetadataConfig.IGNORE_SPURIOUS_DELETES.key() + "` config is set to true"); + } else { throw new HoodieMetadataException("Metadata record for " + partitionName + " is inconsistent: " + hoodieRecord.get().getData()); - } else { - LOG.warn("Metadata record for " + partitionName + " encountered some files to be deleted which was not added before. " - + "Ignoring the spurious deletes as the `" + HoodieMetadataConfig.IGNORE_SPURIOUS_DELETES.key() + "` config is set to false"); } } }