From 71b58bec7d73e445fbf1c4486aab7013226902ba Mon Sep 17 00:00:00 2001 From: yuezhang Date: Wed, 8 Sep 2021 16:40:15 +0800 Subject: [PATCH 1/9] using hbase-shaded-jars-in-hudi-presto-hundle --- packaging/hudi-presto-bundle/pom.xml | 55 ++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/packaging/hudi-presto-bundle/pom.xml b/packaging/hudi-presto-bundle/pom.xml index 7833bda135aaf..94c67fb74d27c 100644 --- a/packaging/hudi-presto-bundle/pom.xml +++ b/packaging/hudi-presto-bundle/pom.xml @@ -158,11 +158,66 @@ org.apache.hudi hudi-common ${project.version} + + + org.apache.hbase + hbase-server + + + org.apache.hbase + hbase-client + + + org.apache.hudi hudi-hadoop-mr-bundle ${project.version} + + + org.apache.hbase + hbase-server + + + org.apache.hbase + hbase-client + + + + + + + org.apache.hbase + hbase-shaded-client + ${hbase.version} + test + + + + org.apache.hbase + hbase-shaded-server + ${hbase.version} + + compile + + + javax.servlet + * + + + org.codehaus.jackson + * + + + org.mortbay.jetty + * + + + tomcat + * + + From 72fc50ea33d6267ebdc9a0ecd81cb4df3c833814 Mon Sep 17 00:00:00 2001 From: yuezhang Date: Wed, 22 Sep 2021 16:57:47 +0800 Subject: [PATCH 2/9] test --- packaging/hudi-presto-bundle/pom.xml | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/packaging/hudi-presto-bundle/pom.xml b/packaging/hudi-presto-bundle/pom.xml index 94c67fb74d27c..e296bcd72abc4 100644 --- a/packaging/hudi-presto-bundle/pom.xml +++ b/packaging/hudi-presto-bundle/pom.xml @@ -158,32 +158,12 @@ org.apache.hudi hudi-common ${project.version} - - - org.apache.hbase - hbase-server - - - org.apache.hbase - hbase-client - - org.apache.hudi hudi-hadoop-mr-bundle ${project.version} - - - org.apache.hbase - hbase-server - - - org.apache.hbase - hbase-client - - From 5e03c2f41cd72d0700a6e9fa8003bb30b2fdf97a Mon Sep 17 00:00:00 2001 From: yuezhang Date: Fri, 24 Sep 2021 12:10:50 +0800 Subject: [PATCH 3/9] add hudi-common-bundle --- packaging/hudi-common-bundle/pom.xml | 129 ++++++++++++++++++ .../org/apache/hudi/common/bundle/Main.java | 36 +++++ pom.xml | 1 + 3 files changed, 166 insertions(+) create mode 100644 packaging/hudi-common-bundle/pom.xml create mode 100644 packaging/hudi-common-bundle/src/main/java/org/apache/hudi/common/bundle/Main.java diff --git a/packaging/hudi-common-bundle/pom.xml b/packaging/hudi-common-bundle/pom.xml new file mode 100644 index 0000000000000..fc17feb1a496d --- /dev/null +++ b/packaging/hudi-common-bundle/pom.xml @@ -0,0 +1,129 @@ + + + + + hudi + org.apache.hudi + 0.10.0-SNAPSHOT + ../../pom.xml + + 4.0.0 + hudi-common-bundle + jar + + + true + ${project.parent.basedir} + + + + + + org.apache.rat + apache-rat-plugin + + + org.apache.maven.plugins + maven-shade-plugin + ${maven-shade-plugin.version} + + + package + + shade + + + true + ${shadeSources} + ${project.build.directory}/dependency-reduced-pom.xml + + + + + + true + + + META-INF/LICENSE + target/classes/META-INF/LICENSE + + + + + org.apache.hudi:hudi-common + org.apache.hbase:hbase-client + org.apache.hbase:hbase-common + org.apache.hbase:hbase-protocol + org.apache.hbase:hbase-server + org.apache.hbase:hbase-annotations + + + + + + org.apache.hadoop.hbase. + org.apache.hudi.org.apache.hadoop.hbase. + + + false + + + *:* + + META-INF/*.SF + META-INF/*.DSA + META-INF/*.RSA + META-INF/services/javax.* + + + + ${project.artifactId}-${project.version} + + + + + + + + src/main/resources + + + src/test/resources + + + + + + + + org.apache.hudi + hudi-common + ${project.version} + + + + + + presto-shade-unbundle-bootstrap + + provided + + + + + diff --git a/packaging/hudi-common-bundle/src/main/java/org/apache/hudi/common/bundle/Main.java b/packaging/hudi-common-bundle/src/main/java/org/apache/hudi/common/bundle/Main.java new file mode 100644 index 0000000000000..463588499ddf6 --- /dev/null +++ b/packaging/hudi-common-bundle/src/main/java/org/apache/hudi/common/bundle/Main.java @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package src.main.java.org.apache.hudi.common.bundle; + +import org.apache.hudi.common.util.ReflectionUtils; + +/** + * A simple main class to dump all classes loaded in current classpath + * + * This is a workaround for generating sources and javadoc jars for packaging modules. The maven plugins for generating + * javadoc and sources plugins do not generate corresponding jars if there are no source files. + * + * This class does not have anything to do with Hudi but is there to keep mvn javadocs/source plugin happy. + */ +public class Main { + + public static void main(String[] args) { + ReflectionUtils.getTopLevelClassesInClasspath(Main.class).forEach(System.out::println); + } +} diff --git a/pom.xml b/pom.xml index a1beac06a32c2..c0883c9921d3f 100644 --- a/pom.xml +++ b/pom.xml @@ -47,6 +47,7 @@ packaging/hudi-hive-sync-bundle packaging/hudi-spark-bundle packaging/hudi-presto-bundle + packaging/hudi-common-bundle packaging/hudi-utilities-bundle packaging/hudi-timeline-server-bundle docker/hoodie/hadoop From 78577241f38f2021052fb62c8c19ed67d0db012e Mon Sep 17 00:00:00 2001 From: yuezhang Date: Fri, 8 Oct 2021 12:13:08 +0800 Subject: [PATCH 4/9] code review --- hudi-common/pom.xml | 4 ++-- packaging/hudi-presto-bundle/pom.xml | 35 ---------------------------- 2 files changed, 2 insertions(+), 37 deletions(-) diff --git a/hudi-common/pom.xml b/hudi-common/pom.xml index 71326e7504e62..08b68b71e3ece 100644 --- a/hudi-common/pom.xml +++ b/hudi-common/pom.xml @@ -218,14 +218,14 @@ org.apache.hbase - hbase-client + hbase-shaded-client ${hbase.version} test org.apache.hbase - hbase-server + hbase-shaded-server ${hbase.version} compile diff --git a/packaging/hudi-presto-bundle/pom.xml b/packaging/hudi-presto-bundle/pom.xml index e296bcd72abc4..7833bda135aaf 100644 --- a/packaging/hudi-presto-bundle/pom.xml +++ b/packaging/hudi-presto-bundle/pom.xml @@ -159,47 +159,12 @@ hudi-common ${project.version} - org.apache.hudi hudi-hadoop-mr-bundle ${project.version} - - - org.apache.hbase - hbase-shaded-client - ${hbase.version} - test - - - - org.apache.hbase - hbase-shaded-server - ${hbase.version} - - compile - - - javax.servlet - * - - - org.codehaus.jackson - * - - - org.mortbay.jetty - * - - - tomcat - * - - - - org.apache.parquet From 44b255665f688477279fce5d07bf29c5537b7f05 Mon Sep 17 00:00:00 2001 From: yuezhang Date: Fri, 8 Oct 2021 12:29:40 +0800 Subject: [PATCH 5/9] code review --- hudi-cli/pom.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hudi-cli/pom.xml b/hudi-cli/pom.xml index 26c0e685a931d..1952013780893 100644 --- a/hudi-cli/pom.xml +++ b/hudi-cli/pom.xml @@ -190,6 +190,10 @@ org.apache.parquet parquet-hadoop-bundle + + * + org.apache.hbase + @@ -197,6 +201,12 @@ org.apache.hudi hudi-utilities-bundle_${scala.binary.version} ${project.version} + + + * + org.apache.hbase + + From b009519a94b039fe319b59899475f37b7c5bb351 Mon Sep 17 00:00:00 2001 From: yuezhang Date: Fri, 8 Oct 2021 12:41:02 +0800 Subject: [PATCH 6/9] code review --- pom.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/pom.xml b/pom.xml index c0883c9921d3f..a1beac06a32c2 100644 --- a/pom.xml +++ b/pom.xml @@ -47,7 +47,6 @@ packaging/hudi-hive-sync-bundle packaging/hudi-spark-bundle packaging/hudi-presto-bundle - packaging/hudi-common-bundle packaging/hudi-utilities-bundle packaging/hudi-timeline-server-bundle docker/hoodie/hadoop From 20c9cfdb70b3652c80fc4339789285473f6a7cbc Mon Sep 17 00:00:00 2001 From: yuezhang Date: Fri, 8 Oct 2021 12:41:49 +0800 Subject: [PATCH 7/9] code review --- packaging/hudi-common-bundle/pom.xml | 129 ------------------ .../org/apache/hudi/common/bundle/Main.java | 36 ----- 2 files changed, 165 deletions(-) delete mode 100644 packaging/hudi-common-bundle/pom.xml delete mode 100644 packaging/hudi-common-bundle/src/main/java/org/apache/hudi/common/bundle/Main.java diff --git a/packaging/hudi-common-bundle/pom.xml b/packaging/hudi-common-bundle/pom.xml deleted file mode 100644 index fc17feb1a496d..0000000000000 --- a/packaging/hudi-common-bundle/pom.xml +++ /dev/null @@ -1,129 +0,0 @@ - - - - - hudi - org.apache.hudi - 0.10.0-SNAPSHOT - ../../pom.xml - - 4.0.0 - hudi-common-bundle - jar - - - true - ${project.parent.basedir} - - - - - - org.apache.rat - apache-rat-plugin - - - org.apache.maven.plugins - maven-shade-plugin - ${maven-shade-plugin.version} - - - package - - shade - - - true - ${shadeSources} - ${project.build.directory}/dependency-reduced-pom.xml - - - - - - true - - - META-INF/LICENSE - target/classes/META-INF/LICENSE - - - - - org.apache.hudi:hudi-common - org.apache.hbase:hbase-client - org.apache.hbase:hbase-common - org.apache.hbase:hbase-protocol - org.apache.hbase:hbase-server - org.apache.hbase:hbase-annotations - - - - - - org.apache.hadoop.hbase. - org.apache.hudi.org.apache.hadoop.hbase. - - - false - - - *:* - - META-INF/*.SF - META-INF/*.DSA - META-INF/*.RSA - META-INF/services/javax.* - - - - ${project.artifactId}-${project.version} - - - - - - - - src/main/resources - - - src/test/resources - - - - - - - - org.apache.hudi - hudi-common - ${project.version} - - - - - - presto-shade-unbundle-bootstrap - - provided - - - - - diff --git a/packaging/hudi-common-bundle/src/main/java/org/apache/hudi/common/bundle/Main.java b/packaging/hudi-common-bundle/src/main/java/org/apache/hudi/common/bundle/Main.java deleted file mode 100644 index 463588499ddf6..0000000000000 --- a/packaging/hudi-common-bundle/src/main/java/org/apache/hudi/common/bundle/Main.java +++ /dev/null @@ -1,36 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package src.main.java.org.apache.hudi.common.bundle; - -import org.apache.hudi.common.util.ReflectionUtils; - -/** - * A simple main class to dump all classes loaded in current classpath - * - * This is a workaround for generating sources and javadoc jars for packaging modules. The maven plugins for generating - * javadoc and sources plugins do not generate corresponding jars if there are no source files. - * - * This class does not have anything to do with Hudi but is there to keep mvn javadocs/source plugin happy. - */ -public class Main { - - public static void main(String[] args) { - ReflectionUtils.getTopLevelClassesInClasspath(Main.class).forEach(System.out::println); - } -} From ede89321fd2c02656b654f023b04a5b08b193fe9 Mon Sep 17 00:00:00 2001 From: yuezhang Date: Mon, 15 Nov 2021 11:28:41 +0800 Subject: [PATCH 8/9] test --- hudi-cli/pom.xml | 10 ------ packaging/hudi-presto-bundle/pom.xml | 54 ++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+), 10 deletions(-) diff --git a/hudi-cli/pom.xml b/hudi-cli/pom.xml index 1952013780893..26c0e685a931d 100644 --- a/hudi-cli/pom.xml +++ b/hudi-cli/pom.xml @@ -190,10 +190,6 @@ org.apache.parquet parquet-hadoop-bundle - - * - org.apache.hbase - @@ -201,12 +197,6 @@ org.apache.hudi hudi-utilities-bundle_${scala.binary.version} ${project.version} - - - * - org.apache.hbase - - diff --git a/packaging/hudi-presto-bundle/pom.xml b/packaging/hudi-presto-bundle/pom.xml index 7833bda135aaf..711914aec3f6c 100644 --- a/packaging/hudi-presto-bundle/pom.xml +++ b/packaging/hudi-presto-bundle/pom.xml @@ -158,11 +158,65 @@ org.apache.hudi hudi-common ${project.version} + + + org.apache.hbase + hbase-server + + + org.apache.hbase + hbase-client + + org.apache.hudi hudi-hadoop-mr-bundle ${project.version} + + + org.apache.hbase + hbase-server + + + org.apache.hbase + hbase-client + + + + + + + org.apache.hbase + hbase-shaded-client + ${hbase.version} + test + + + + org.apache.hbase + hbase-shaded-server + ${hbase.version} + + compile + + + javax.servlet + * + + + org.codehaus.jackson + * + + + org.mortbay.jetty + * + + + tomcat + * + + From 7781df5cec932702e4f5e1c88e59fc4cc6de0e9b Mon Sep 17 00:00:00 2001 From: yuezhang Date: Mon, 15 Nov 2021 13:18:06 +0800 Subject: [PATCH 9/9] test --- hudi-common/pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hudi-common/pom.xml b/hudi-common/pom.xml index 5f55deda678c6..bbf2b2972910d 100644 --- a/hudi-common/pom.xml +++ b/hudi-common/pom.xml @@ -218,14 +218,14 @@ org.apache.hbase - hbase-shaded-client + hbase-client ${hbase.version} test org.apache.hbase - hbase-shaded-server + hbase-server ${hbase.version} compile