diff --git a/hudi-common/src/main/java/org/apache/hudi/common/config/LockConfiguration.java b/hudi-common/src/main/java/org/apache/hudi/common/config/LockConfiguration.java index ffb4afe5c3ccd..2a1eea3002f29 100644 --- a/hudi-common/src/main/java/org/apache/hudi/common/config/LockConfiguration.java +++ b/hudi-common/src/main/java/org/apache/hudi/common/config/LockConfiguration.java @@ -27,7 +27,7 @@ */ public class LockConfiguration implements Serializable { - public static final String LOCK_PREFIX = "hoodie.writer.lock."; + public static final String LOCK_PREFIX = "hoodie.write.lock."; public static final String LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS_PROP = LOCK_PREFIX + "wait_time_ms_between_retry"; public static final String DEFAULT_LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS = String.valueOf(5000L); public static final String LOCK_ACQUIRE_RETRY_MAX_WAIT_TIME_IN_MILLIS_PROP = LOCK_PREFIX + "max_wait_time_ms_between_retry"; diff --git a/hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/job/TestHoodieTestSuiteJob.java b/hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/job/TestHoodieTestSuiteJob.java index 30829eac77caa..ce32ccff49a63 100644 --- a/hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/job/TestHoodieTestSuiteJob.java +++ b/hudi-integ-test/src/test/java/org/apache/hudi/integ/testsuite/job/TestHoodieTestSuiteJob.java @@ -171,15 +171,15 @@ private static TypedProperties getProperties() { props.setProperty(DataSourceWriteOptions.HIVE_PARTITION_FIELDS_OPT_KEY(), "datestr"); props.setProperty(DataSourceWriteOptions.KEYGENERATOR_CLASS_OPT_KEY(), TimestampBasedKeyGenerator.class.getName()); - props.setProperty("hoodie.writer.lock.provider", "org.apache.hudi.client.transaction.lock.ZookeeperBasedLockProvider"); - props.setProperty("hoodie.writer.lock.hivemetastore.database", "testdb1"); - props.setProperty("hoodie.writer.lock.hivemetastore.table", "table1"); - props.setProperty("hoodie.writer.lock.zookeeper.url", "127.0.0.1"); - props.setProperty("hoodie.writer.lock.zookeeper.port", "2828"); - props.setProperty("hoodie.writer.lock.wait_time_ms", "1200000"); - props.setProperty("hoodie.writer.lock.num_retries", "10"); - props.setProperty("hoodie.writer.lock.zookeeper.lock_key", "test_table"); - props.setProperty("hoodie.writer.lock.zookeeper.zk_base_path", "/test"); + props.setProperty("hoodie.write.lock.provider", "org.apache.hudi.client.transaction.lock.ZookeeperBasedLockProvider"); + props.setProperty("hoodie.write.lock.hivemetastore.database", "testdb1"); + props.setProperty("hoodie.write.lock.hivemetastore.table", "table1"); + props.setProperty("hoodie.write.lock.zookeeper.url", "127.0.0.1"); + props.setProperty("hoodie.write.lock.zookeeper.port", "2828"); + props.setProperty("hoodie.write.lock.wait_time_ms", "1200000"); + props.setProperty("hoodie.write.lock.num_retries", "10"); + props.setProperty("hoodie.write.lock.zookeeper.lock_key", "test_table"); + props.setProperty("hoodie.write.lock.zookeeper.zk_base_path", "/test"); return props; } diff --git a/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java b/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java index 359d7c077cb07..cb59ce7b1d380 100644 --- a/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java +++ b/hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java @@ -290,15 +290,15 @@ protected static TypedProperties prepareMultiWriterProps(String propsFileName) t props.setProperty("include", "base.properties"); props.setProperty("hoodie.write.concurrency.mode", "optimistic_concurrency_control"); props.setProperty("hoodie.failed.writes.cleaner.policy", "LAZY"); - props.setProperty("hoodie.writer.lock.provider", "org.apache.hudi.client.transaction.lock.ZookeeperBasedLockProvider"); - props.setProperty("hoodie.writer.lock.hivemetastore.database", "testdb1"); - props.setProperty("hoodie.writer.lock.hivemetastore.table", "table1"); - props.setProperty("hoodie.writer.lock.zookeeper.url", "127.0.0.1"); - props.setProperty("hoodie.writer.lock.zookeeper.port", "2828"); - props.setProperty("hoodie.writer.lock.wait_time_ms", "1200000"); - props.setProperty("hoodie.writer.lock.num_retries", "10"); - props.setProperty("hoodie.writer.lock.zookeeper.lock_key", "test_table"); - props.setProperty("hoodie.writer.lock.zookeeper.zk_base_path", "/test"); + props.setProperty("hoodie.write.lock.provider", "org.apache.hudi.client.transaction.lock.ZookeeperBasedLockProvider"); + props.setProperty("hoodie.write.lock.hivemetastore.database", "testdb1"); + props.setProperty("hoodie.write.lock.hivemetastore.table", "table1"); + props.setProperty("hoodie.write.lock.zookeeper.url", "127.0.0.1"); + props.setProperty("hoodie.write.lock.zookeeper.port", "2828"); + props.setProperty("hoodie.write.lock.wait_time_ms", "1200000"); + props.setProperty("hoodie.write.lock.num_retries", "10"); + props.setProperty("hoodie.write.lock.zookeeper.lock_key", "test_table"); + props.setProperty("hoodie.write.lock.zookeeper.zk_base_path", "/test"); UtilitiesTestBase.Helpers.savePropsToDFS(props, dfs, dfsBasePath + "/" + propsFileName); return props; @@ -743,8 +743,8 @@ private void testUpsertsContinuousModeWithMultipleWriters(HoodieTableType tableT String tableBasePath = dfsBasePath + "/" + tempDir; // enable carrying forward latest checkpoint TypedProperties props = prepareMultiWriterProps(PROPS_FILENAME_TEST_MULTI_WRITER); - props.setProperty("hoodie.writer.lock.provider", "org.apache.hudi.client.transaction.FileSystemBasedLockProviderTestClass"); - props.setProperty("hoodie.writer.lock.filesystem.path", tableBasePath); + props.setProperty("hoodie.write.lock.provider", "org.apache.hudi.client.transaction.FileSystemBasedLockProviderTestClass"); + props.setProperty("hoodie.write.lock.filesystem.path", tableBasePath); UtilitiesTestBase.Helpers.savePropsToDFS(props, dfs, dfsBasePath + "/" + PROPS_FILENAME_TEST_MULTI_WRITER); // Keep it higher than batch-size to test continuous mode int totalRecords = 3000; @@ -793,8 +793,8 @@ private void testUpsertsContinuousModeWithMultipleWriters(HoodieTableType tableT // create new ingestion & backfill job config to generate only INSERTS to avoid conflict props = prepareMultiWriterProps(PROPS_FILENAME_TEST_MULTI_WRITER); - props.setProperty("hoodie.writer.lock.provider", "org.apache.hudi.client.transaction.FileSystemBasedLockProviderTestClass"); - props.setProperty("hoodie.writer.lock.filesystem.path", tableBasePath); + props.setProperty("hoodie.write.lock.provider", "org.apache.hudi.client.transaction.FileSystemBasedLockProviderTestClass"); + props.setProperty("hoodie.write.lock.filesystem.path", tableBasePath); props.setProperty("hoodie.test.source.generate.inserts", "true"); UtilitiesTestBase.Helpers.savePropsToDFS(props, dfs, dfsBasePath + "/" + PROPS_FILENAME_TEST_MULTI_WRITER); cfgBackfillJob = TestHelpers.makeConfig(tableBasePath, WriteOperationType.INSERT, @@ -830,8 +830,8 @@ private void testLatestCheckpointCarryOverWithMultipleWriters(HoodieTableType ta String tableBasePath = dfsBasePath + "/" + tempDir; // enable carrying forward latest checkpoint TypedProperties props = prepareMultiWriterProps(PROPS_FILENAME_TEST_MULTI_WRITER); - props.setProperty("hoodie.writer.lock.provider", "org.apache.hudi.client.transaction.FileSystemBasedLockProviderTestClass"); - props.setProperty("hoodie.writer.lock.filesystem.path", tableBasePath); + props.setProperty("hoodie.write.lock.provider", "org.apache.hudi.client.transaction.FileSystemBasedLockProviderTestClass"); + props.setProperty("hoodie.write.lock.filesystem.path", tableBasePath); UtilitiesTestBase.Helpers.savePropsToDFS(props, dfs, dfsBasePath + "/" + PROPS_FILENAME_TEST_MULTI_WRITER); // Keep it higher than batch-size to test continuous mode int totalRecords = 3000; @@ -874,8 +874,8 @@ private void testLatestCheckpointCarryOverWithMultipleWriters(HoodieTableType ta // run the backfill job, enable overriding checkpoint from the latest commit props = prepareMultiWriterProps(PROPS_FILENAME_TEST_MULTI_WRITER); - props.setProperty("hoodie.writer.lock.provider", "org.apache.hudi.client.transaction.FileSystemBasedLockProviderTestClass"); - props.setProperty("hoodie.writer.lock.filesystem.path", tableBasePath); + props.setProperty("hoodie.write.lock.provider", "org.apache.hudi.client.transaction.FileSystemBasedLockProviderTestClass"); + props.setProperty("hoodie.write.lock.filesystem.path", tableBasePath); props.setProperty("hoodie.write.meta.key.prefixes", CHECKPOINT_KEY); UtilitiesTestBase.Helpers.savePropsToDFS(props, dfs, dfsBasePath + "/" + PROPS_FILENAME_TEST_MULTI_WRITER);