Skip to content

[HUDI-7207] Sequentially delete complete instant files in archival to prevent inconsistency during data reads #10711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Feb 22, 2024
Merged

[HUDI-7207] Sequentially delete complete instant files in archival to prevent inconsistency during data reads #10711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...lient/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,11 +594,13 @@ private boolean deleteArchivedInstants(List<HoodieInstant> archivedInstants, Hoo
);
}
if (!completedInstants.isEmpty()) {
context.foreach(
completedInstants,
instant -> activeTimeline.deleteInstantFileIfExists(instant),
Math.min(completedInstants.size(), config.getArchiveDeleteParallelism())
);
// Due to the concurrency between deleting completed instants and reading data,
// there may be hole in the timeline, which can lead to errors when reading data.
// Therefore, the concurrency of deleting completed instants is temporarily disabled,
// and instants are deleted in ascending order to prevent the occurrence of such holes.
// See HUDI-7207 and #10325.
completedInstants.stream()
.forEach(instant -> activeTimeline.deleteInstantFileIfExists(instant));
}

return true;
Expand Down