From 167d771f66800586fc2ba180c074b7a96d54ed0b Mon Sep 17 00:00:00 2001 From: lamber-ken Date: Mon, 18 Nov 2019 22:14:08 +0800 Subject: [PATCH 1/3] [HUDI-342] add pull request template for hudi project --- .github/PULL_REQUEST_TEMPLATE.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000000..536c260f26050 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,17 @@ +## *Tips* +- *Thank you very much for contributing to Apache Hudi.* +- *Please review https://hudi.apache.org/contributing.html before opening a pull request.* + +## What is the purpose of the pull request + +*(For example: This pull request adds quick-start document.)* + +## Verify this pull request + +*(Please pick either of the following options)* + +This pull request is a trivial rework / code cleanup without any test coverage. + +*(or)* + +This pull request is already covered by existing tests, such as *(please describe tests)*. \ No newline at end of file From 52667c81e040adf9566e02b040e8fdd0bbc1463c Mon Sep 17 00:00:00 2001 From: lamber-ken Date: Tue, 19 Nov 2019 10:29:25 +0800 Subject: [PATCH 2/3] update pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 536c260f26050..bd2f3b4c5bd8a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,6 +6,11 @@ *(For example: This pull request adds quick-start document.)* +## Brief change log + +*(for example:)* + - *Modify AnnotationLocation checkstyle rule in checkstyle.xml* + ## Verify this pull request *(Please pick either of the following options)* @@ -14,4 +19,16 @@ This pull request is a trivial rework / code cleanup without any test coverage. *(or)* -This pull request is already covered by existing tests, such as *(please describe tests)*. \ No newline at end of file +This pull request is already covered by existing tests, such as *(please describe tests)*. + +## Committer checklist + + - [ ] Has a corresponding JIRA in PR title & commit + + - [ ] Commit message is descriptive of the change + + - [ ] CI is green + + - [ ] Necessary doc changes done or have another open PR + + - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \ No newline at end of file From 7cdebaa381061b9eb9c4dd0ebb57eb24b4ff01b9 Mon Sep 17 00:00:00 2001 From: lamber-ken Date: Tue, 19 Nov 2019 13:14:21 +0800 Subject: [PATCH 3/3] update pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index bd2f3b4c5bd8a..e6da7e3aa350c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -21,6 +21,16 @@ This pull request is a trivial rework / code cleanup without any test coverage. This pull request is already covered by existing tests, such as *(please describe tests)*. +(or) + +This change added tests and can be verified as follows: + +*(example:)* + + - *Added integration tests for end-to-end.* + - *Added HoodieClientWriteTest to verify the change.* + - *Manually verified the change by running a job locally.* + ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit