Skip to content

[HUDI-339] Add support of Azure cloud storage #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinothchandar merged 7 commits into from
Nov 17, 2019
Merged

[HUDI-339] Add support of Azure cloud storage #1019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
347b6a7
Add support of Azure storages
broussea1901 Nov 16, 2019
bfd790f
Fix typo
broussea1901 Nov 16, 2019
6919f85
Update testStorageSchemes to test new added storage
broussea1901 Nov 17, 2019
51689b2
Fix URI for ADLS
broussea1901 Nov 17, 2019
bd196c5
Fix test URI for ADLS
broussea1901 Nov 17, 2019
ec6d28e
Add support for Azure ADLS Gen2
broussea1901 Nov 17, 2019
2b5375f
Add support for Azure ADLS Gen2
broussea1901 Nov 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hudi-common/src/main/java/org/apache/hudi/common/storage/StorageSchemes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ public enum StorageSchemes {
S3A("s3a", false), S3("s3", false),
// Google Cloud Storage
GCS("gs", false),
// Azure WASB
WASB("wasb", false), WASBS("wasbs", false),
Copy link
Member

@vinothchandar vinothchandar Nov 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure-datalake/src/main/java/org/apache/hadoop/fs/adl/AdlFileSystem.java#L445
https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java#L1575
https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java#L246

All suggest append support? Stumbled onto it as I was trying to read up on this..

actually, this is so awesome, if it has append support :)

Copy link
Contributor Author

@broussea1901 broussea1901 Nov 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how Spark manages append on WASB.
Hadoop implementation of WASB is designed for single thread append:
https://hadoop.apache.org/docs/current/hadoop-azure/index.html#Append_API_Support_and_Configuration
https://issues.apache.org/jira/browse/HADOOP-12635

Copy link
Contributor

@n3nash n3nash Nov 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, HDFS append implementation guarantees single writer by having a lease on the file, looks like Azure implementation doesn't provide that guarantee..In Hudi, we have a single writer model for append usages but Spark dag retries complicates this and introduces multi-writer appends

Copy link
Member

@vinothchandar vinothchandar Nov 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n3nash fair.. can we create a JIRA for tracking this ? Seems like something we should play with and understand.. I assume you have reading material on the append semantics..

Copy link
Contributor

@n3nash n3nash Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/HUDI-341

// Azure ADLS
ADL("adl", false),
// Azure ADLS Gen2
ABFS("abfs", false), ABFSS("abfss", false),
// View FS for federated setups. If federating across cloud stores, then append support is false
VIEWFS("viewfs", true);

Expand Down
3 changes: 3 additions & 0 deletions hudi-common/src/test/java/org/apache/hudi/common/storage/TestStorageSchemes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ public void testStorageSchemes() {
assertFalse(StorageSchemes.isSchemeSupported("s2"));
assertFalse(StorageSchemes.isAppendSupported("s3a"));
assertFalse(StorageSchemes.isAppendSupported("gs"));
assertFalse(StorageSchemes.isAppendSupported("wasb"));
assertFalse(StorageSchemes.isAppendSupported("adl"));
assertFalse(StorageSchemes.isAppendSupported("abfs"));
assertTrue(StorageSchemes.isAppendSupported("viewfs"));
try {
StorageSchemes.isAppendSupported("s2");
Expand Down