add experimental RFC 9218 Priority header support. #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
requested changes
Oct 17, 2025
Member
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
@arturobernalg Still needs work.
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/H2AsyncClientBuilder.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
...client5/src/test/java/org/apache/hc/client5/http/examples/ClientH2PriorityHeaderExample.java
Outdated
Show resolved
Hide resolved
arturobernalg
force-pushed
the
rfc9218
branch
from
c9e08c5 to
f0b21b6
Compare
Member
Author
|
@ok2c do another pass |
ok2c
reviewed
Oct 18, 2025
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/H2AsyncClientBuilder.java
Outdated
Show resolved
Hide resolved
ok2c
reviewed
Oct 18, 2025
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
ok2c
requested changes
Oct 18, 2025
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java
Show resolved
Hide resolved
arturobernalg
force-pushed
the
rfc9218
branch
from
b3f212f to
3d5b398
Compare
arturobernalg
force-pushed
the
rfc9218
branch
from
2007b5a to
d6fba2c
Compare
ok2c
requested changes
Oct 19, 2025
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/H2AsyncClientBuilder.java
Outdated
Show resolved
Hide resolved
arturobernalg
force-pushed
the
rfc9218
branch
from
aa285a4 to
b3a8326
Compare
ok2c
reviewed
Oct 19, 2025
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/H2RequestPriority.java
Outdated
Show resolved
Hide resolved
ok2c
approved these changes
Oct 19, 2025
arturobernalg
force-pushed
the
rfc9218
branch
from
45ad639 to
e64153e
Compare
Wire H2RequestPriority via H2AsyncClientBuilder.enablePriorityHeader(); omit on defaults, allow overwrite.
arturobernalg
force-pushed
the
rfc9218
branch
from
e64153e to
232773f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire H2RequestPriority via H2AsyncClientBuilder.enablePriorityHeader(); omit on defaults, allow overwrite.