Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace protobuf with prost used by protos crate so to remove grpcio dependencies #346

Closed
ShiKaiWi opened this issue Oct 27, 2022 · 0 comments · Fixed by #352
Closed

Replace protobuf with prost used by protos crate so to remove grpcio dependencies #346

ShiKaiWi opened this issue Oct 27, 2022 · 0 comments · Fixed by #352
Labels
feature New feature or request

Comments

@ShiKaiWi
Copy link
Member

Describe This Problem

Current the protos crate uses the protobuf dependency to generate codes, but it introduces a huge dependency grpcio, which makes the binary size larger and compiling time longer.

Proposal

Let's replace protobuf crate with the prost crate.

Additional Context

This may be helpful for #294
@ShiKaiWi ShiKaiWi added the feature New feature or request label Oct 27, 2022
@ShiKaiWi ShiKaiWi mentioned this issue Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor replace protobuf with prost ShiKaiWi/ceresdb
1 participant
@ShiKaiWi