HIVE-27472: Iceberg: Disallow creation of temporary tables

Author: deniskuzZ

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java

@@ -165,6 +165,9 @@ public HiveIcebergMetaHook(Configuration conf) {
 
   @Override
   public void preCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTable) {
+    if (hmsTable.isTemporary()) {
+      throw new UnsupportedOperationException("Creation of iceberg temporary tables is not supported.");
+    }
     this.catalogProperties = getCatalogProperties(hmsTable);
 
     // Set the table type even for non HiveCatalog based tables
@@ -173,7 +176,7 @@ public void preCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTable)
 
     if (!Catalogs.hiveCatalog(conf, catalogProperties)) {
       if (Boolean.parseBoolean(this.catalogProperties.getProperty(hive_metastoreConstants.TABLE_IS_CTLT))) {
-        throw new RuntimeException("CTLT target table must be a HiveCatalog table.");
+        throw new UnsupportedOperationException("CTLT target table must be a HiveCatalog table.");
       }
       // For non-HiveCatalog tables too, we should set the input and output format
       // so that the table can be read by other engines like Impala

iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java

@@ -1659,13 +1659,27 @@ public void testCTLTHiveCatalogValidation() throws TException, InterruptedExcept
 
     // Run a CTLT query.
     AssertHelpers.assertThrows("should throw exception", IllegalArgumentException.class,
-        " CTLT target table must be a HiveCatalog table", () -> {
+        "CTLT target table must be a HiveCatalog table", () -> {
           shell.executeStatement(String.format("CREATE TABLE dest LIKE source STORED BY ICEBERG %s %s",
               testTables.locationForCreateTableSQL(TableIdentifier.of("default", "dest")),
               testTables.propertiesForCreateTableSQL(ImmutableMap.of())));
         });
   }
 
+  @Test
+  public void testCreateTemporaryTable() {
+    TableIdentifier identifier = TableIdentifier.of("default", "customers");
+    String query = String.format("CREATE temporary TABLE customers (customer_id BIGINT, first_name STRING, last_name " +
+        "STRING) STORED BY iceberg %s %s",
+      testTables.locationForCreateTableSQL(identifier),
+      testTables.propertiesForCreateTableSQL(ImmutableMap.of()));
+
+    AssertHelpers.assertThrows("should throw exception", IllegalArgumentException.class,
+      "Creation of iceberg temporary tables is not supported", () -> {
+        shell.executeStatement(query);
+      });
+  }
+
   @Test
   public void testParquetHiveCatalogValidation() throws TException, InterruptedException, IOException {