From 400b36ad7e8654fe6724c61634395a5a86cd39e6 Mon Sep 17 00:00:00 2001 From: Peter Somogyi Date: Wed, 11 Jan 2023 14:48:50 +0100 Subject: [PATCH] HBASE-27565 Make the initial corePoolSize configurable for ChoreService --- .../src/main/java/org/apache/hadoop/hbase/ChoreService.java | 6 ++++++ .../main/java/org/apache/hadoop/hbase/HBaseServerBase.java | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java index 01f813561903..8b1e5732663f 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java @@ -59,6 +59,12 @@ public class ChoreService { */ @InterfaceAudience.Private public final static int MIN_CORE_POOL_SIZE = 1; + /** + * The initial number of threads in the core pool for the {@link ChoreService}. + */ + public static final String CHORE_SERVICE_INITIAL_POOL_SIZE = + "hbase.choreservice.initial.pool.size"; + public static final int DEFAULT_CHORE_SERVICE_INITIAL_POOL_SIZE = 1; /** * This thread pool is used to schedule all of the Chores diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java index 11e6b07a040c..95fcc36701a3 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java @@ -17,6 +17,8 @@ */ package org.apache.hadoop.hbase; +import static org.apache.hadoop.hbase.ChoreService.CHORE_SERVICE_INITIAL_POOL_SIZE; +import static org.apache.hadoop.hbase.ChoreService.DEFAULT_CHORE_SERVICE_INITIAL_POOL_SIZE; import static org.apache.hadoop.hbase.HConstants.DEFAULT_HBASE_SPLIT_COORDINATED_BY_ZK; import static org.apache.hadoop.hbase.HConstants.HBASE_SPLIT_WAL_COORDINATED_BY_ZK; @@ -278,7 +280,9 @@ public HBaseServerBase(Configuration conf, String name) throws IOException { initializeFileSystem(); - this.choreService = new ChoreService(getName(), true); + int choreServiceInitialSize = + conf.getInt(CHORE_SERVICE_INITIAL_POOL_SIZE, DEFAULT_CHORE_SERVICE_INITIAL_POOL_SIZE); + this.choreService = new ChoreService(getName(), choreServiceInitialSize, true); this.executorService = new ExecutorService(getName()); this.metaRegionLocationCache = new MetaRegionLocationCache(zooKeeper);