From 968a0d57e8cb6905895eb14f96f7e300fc9b6d4f Mon Sep 17 00:00:00 2001 From: skysiders Date: Thu, 28 Apr 2022 12:04:37 +0800 Subject: [PATCH 1/2] check permission for SecureBulkLoadManager --- .../hadoop/hbase/regionserver/SecureBulkLoadManager.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java index c28d3b09888a..bd0fd4ec2e7b 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java @@ -132,6 +132,10 @@ public void start() throws IOException { } if (!fs.exists(baseStagingDir)) { fs.mkdirs(baseStagingDir, PERM_HIDDEN); + if (!PERM_HIDDEN.equals(PERM_HIDDEN.applyUMask(FsPermission.getUMask(conf)))) { + LOG.info("Modifying permissions to " + PERM_HIDDEN); + fileSystem.setPermission(baseStagingDir, PERM_HIDDEN); + } } } From 447d42fd66196178efc28001f4b68b199940365c Mon Sep 17 00:00:00 2001 From: skysiders Date: Sat, 30 Apr 2022 11:24:28 +0800 Subject: [PATCH 2/2] fix some mistake --- .../apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java index bd0fd4ec2e7b..ea76a08ca50f 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java @@ -134,7 +134,7 @@ public void start() throws IOException { fs.mkdirs(baseStagingDir, PERM_HIDDEN); if (!PERM_HIDDEN.equals(PERM_HIDDEN.applyUMask(FsPermission.getUMask(conf)))) { LOG.info("Modifying permissions to " + PERM_HIDDEN); - fileSystem.setPermission(baseStagingDir, PERM_HIDDEN); + fs.setPermission(baseStagingDir, PERM_HIDDEN); } } }