From ed43153579fb1e724cb4fbb2d9735269c08c56e9 Mon Sep 17 00:00:00 2001 From: Zheng Wang <18031031@qq.com> Date: Thu, 6 Aug 2020 17:09:22 +0800 Subject: [PATCH 1/3] HBASE-24826 Add some comments for processlist in hbase shell --- hbase-shell/src/main/ruby/shell/commands/processlist.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hbase-shell/src/main/ruby/shell/commands/processlist.rb b/hbase-shell/src/main/ruby/shell/commands/processlist.rb index cfb568f51827..53e3968f0855 100644 --- a/hbase-shell/src/main/ruby/shell/commands/processlist.rb +++ b/hbase-shell/src/main/ruby/shell/commands/processlist.rb @@ -27,10 +27,10 @@ def help hbase> processlist hbase> processlist 'all' - hbase> processlist 'general' - hbase> processlist 'handler' - hbase> processlist 'rpc' - hbase> processlist 'operation' + hbase> processlist 'general' //non-RPC Tasks, such as compact, flush etc + hbase> processlist 'handler' //RPC Handler Tasks + hbase> processlist 'rpc' //RPC Handler Tasks which state is RUNNING + hbase> processlist 'operation' //RPC Handler Tasks which state is RUNNING and from client hbase> processlist 'all','host187.example.com' hbase> processlist 'all','host187.example.com,16020' hbase> processlist 'all','host187.example.com,16020,1289493121758' From 71c53947ec804104fed735912dc115595861a753 Mon Sep 17 00:00:00 2001 From: Zheng Wang <18031031@qq.com> Date: Fri, 7 Aug 2020 09:59:21 +0800 Subject: [PATCH 2/3] fix review issue --- .../src/main/ruby/shell/commands/processlist.rb | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hbase-shell/src/main/ruby/shell/commands/processlist.rb b/hbase-shell/src/main/ruby/shell/commands/processlist.rb index 53e3968f0855..42cd490a5ed9 100644 --- a/hbase-shell/src/main/ruby/shell/commands/processlist.rb +++ b/hbase-shell/src/main/ruby/shell/commands/processlist.rb @@ -27,10 +27,15 @@ def help hbase> processlist hbase> processlist 'all' - hbase> processlist 'general' //non-RPC Tasks, such as compact, flush etc - hbase> processlist 'handler' //RPC Handler Tasks - hbase> processlist 'rpc' //RPC Handler Tasks which state is RUNNING - hbase> processlist 'operation' //RPC Handler Tasks which state is RUNNING and from client + + # list non-RPC Tasks, such as compact, flush etc + hbase> processlist 'general' + # list RPC Handler Tasks + hbase> processlist 'handler' + # list RPC Handler Tasks which state is RUNNING + hbase> processlist 'rpc' + # list RPC Handler Tasks which state is RUNNING and from client + hbase> processlist 'operation' hbase> processlist 'all','host187.example.com' hbase> processlist 'all','host187.example.com,16020' hbase> processlist 'all','host187.example.com,16020,1289493121758' From 82c3af32d66a731a0da153ddb9e20a863af2265c Mon Sep 17 00:00:00 2001 From: Zheng Wang <18031031@qq.com> Date: Fri, 7 Aug 2020 10:01:33 +0800 Subject: [PATCH 3/3] remove blank line --- hbase-shell/src/main/ruby/shell/commands/processlist.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/hbase-shell/src/main/ruby/shell/commands/processlist.rb b/hbase-shell/src/main/ruby/shell/commands/processlist.rb index 42cd490a5ed9..4b61886d66d1 100644 --- a/hbase-shell/src/main/ruby/shell/commands/processlist.rb +++ b/hbase-shell/src/main/ruby/shell/commands/processlist.rb @@ -27,7 +27,6 @@ def help hbase> processlist hbase> processlist 'all' - # list non-RPC Tasks, such as compact, flush etc hbase> processlist 'general' # list RPC Handler Tasks